Hopiu/llm
1
0
Fork 0
mirror of https://github.com/Hopiu/llm.git synced 2026-05-05 04:14:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Drop llm.EmbeddingModel.embedding_size property, closes #208

Browse source
This commit is contained in:
Simon Willison 2023-09-02 08:45:17 -07:00
parent 3d56d6cc24
commit e49c816e18
3 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
docs/embeddings/writing-plugins.md
View file

@ -22,14 +22,13 @@ from sentence_transformers import SentenceTransformer
@llm.hookimpl
def register_embedding_models(register):
model_id = "sentence-transformers/all-MiniLM-L6-v2"
register(SentenceTransformerModel(model_id, model_id, 384), aliases=("all-MiniLM-L6-v2",))
register(SentenceTransformerModel(model_id, model_id), aliases=("all-MiniLM-L6-v2",))
class SentenceTransformerModel(llm.EmbeddingModel):
def __init__(self, model_id, model_name, embedding_size):
def __init__(self, model_id, model_name):
self.model_id = model_id
self.model_name = model_name
self.embedding_size = embedding_size
self._model = None
def embed_batch(self, texts):

1
llm/default_plugins/openai_models.py
View file

@ -63,7 +63,6 @@ def register_embedding_models(register):
class Ada002(EmbeddingModel):
model_id = "ada-002"
embedding_size = 1536
needs_key = "openai"
key_env_var = "OPENAI_API_KEY"
batch_size = 100 # Maybe this should be 2048

1
llm/models.py
View file

@ -288,7 +288,6 @@ class Model(ABC, _get_key_mixin):
class EmbeddingModel(ABC, _get_key_mixin):
model_id: str
embedding_size: int
key: Optional[str] = None
needs_key: Optional[str] = None
key_env_var: Optional[str] = None