From c9edb7f8097c1247589ceeeeffbc06c0c930f5de Mon Sep 17 00:00:00 2001 From: Matthias Date: Thu, 2 Mar 2023 17:26:00 +0100 Subject: [PATCH] Split up quirks and skip twitter check It's flaky on Github --- fixtures/TEST_QUIRKS.txt | 3 --- lychee-bin/tests/cli.rs | 43 +++++++++++++++++++++++++++++++++++----- 2 files changed, 38 insertions(+), 8 deletions(-) delete mode 100644 fixtures/TEST_QUIRKS.txt diff --git a/fixtures/TEST_QUIRKS.txt b/fixtures/TEST_QUIRKS.txt deleted file mode 100644 index 4df1d97..0000000 --- a/fixtures/TEST_QUIRKS.txt +++ /dev/null @@ -1,3 +0,0 @@ -https://www.youtube.com/watch?v=NlKuICiT470&list=PLbWDhxwM_45mPVToqaIZNbZeIzFchsKKQ&index=7 -https://twitter.com/zarfeblong/status/1339742840142872577 -https://crates.io/crates/lychee \ No newline at end of file diff --git a/lychee-bin/tests/cli.rs b/lychee-bin/tests/cli.rs index 0314cfb..572e626 100644 --- a/lychee-bin/tests/cli.rs +++ b/lychee-bin/tests/cli.rs @@ -239,16 +239,49 @@ mod cli { } #[test] - fn test_quirks() { - let quirks_file = fixtures_path().join("TEST_QUIRKS.txt"); + fn test_youtube_quirk() { + let url = "https://www.youtube.com/watch?v=NlKuICiT470&list=PLbWDhxwM_45mPVToqaIZNbZeIzFchsKKQ&index=7"; + main_command() + .write_stdin(url) .arg("--verbose") .arg("--no-progress") - .arg(quirks_file) + .arg("-") .assert() .success() - .stdout(contains("3 Total")) - .stdout(contains("3 OK")); + .stdout(contains("1 Total")) + .stdout(contains("1 OK")); + } + + #[test] + fn test_cratesio_quirk() { + let url = "https://crates.io/crates/lychee"; + + main_command() + .write_stdin(url) + .arg("--verbose") + .arg("--no-progress") + .arg("-") + .assert() + .success() + .stdout(contains("1 Total")) + .stdout(contains("1 OK")); + } + + #[test] + #[ignore = "Twitter quirk works locally but is flaky on Github (timeout)"] + fn test_twitter_quirk() { + let url = "https://twitter.com/zarfeblong/status/1339742840142872577"; + + main_command() + .write_stdin(url) + .arg("--verbose") + .arg("--no-progress") + .arg("-") + .assert() + .success() + .stdout(contains("1 Total")) + .stdout(contains("1 OK")); } #[tokio::test]