From de55fbd178ab90da724ea1032553157f7ec0f5dc Mon Sep 17 00:00:00 2001
From: Matthias <matthias-endler@gmx.net>
Date: Thu, 9 Sep 2021 19:31:49 +0200
Subject: [PATCH] Add TODO for fixing URL encoding for paths

---
 lychee-lib/src/extract.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lychee-lib/src/extract.rs b/lychee-lib/src/extract.rs
index 1bbf059..fcb4bcc 100644
--- a/lychee-lib/src/extract.rs
+++ b/lychee-lib/src/extract.rs
@@ -130,6 +130,10 @@ fn create_uri_from_path(src: &Path, base: &Option<Base>, dst: &str) -> Result<Ur
     // That's because Url::from_file_path will encode the full URL in the end.
     // This behavior cannot be configured.
     // See https://github.com/lycheeverse/lychee/pull/262#issuecomment-915245411
+    // TODO: This is not a perfect solution.
+    // Ideally, only `src` and `base` should be URL encoded (as is done by
+    // `from_file_path` at the moment) while `dst` is left untouched and simply
+    // appended to the end.
     let decoded = percent_decode_str(dst).decode_utf8()?.to_string();
     let path = path::resolve(src, &PathBuf::from(decoded), base)?;
     Url::from_file_path(&path).map_err(|_e| ErrorKind::InvalidUrl(path))