Add comments, reactivate integration test

This commit is contained in:
Matthias Endler 2021-03-29 00:29:29 +02:00
parent 0c0b91a727
commit e28132b8a9
2 changed files with 7 additions and 3 deletions

View file

@ -20,6 +20,10 @@ impl Default for Quirks {
fn default() -> Self {
let quirks = vec![
Quirk {
// Twitter cut off the ability to read a tweet by fetching its
// URL with a normal HTTP GET. Only Googlebot will get a plain
// HTML response.
// See https://twitter.com/zarfeblong/status/1339742840142872577
pattern: Regex::new(r"^(https?://)?(www\.)?twitter.com").unwrap(),
rewrite: |request| {
let mut out = request;
@ -30,7 +34,9 @@ impl Default for Quirks {
},
},
Quirk {
// https://stackoverflow.com/a/19377429/270334
// The https://www.youtube.com/oembed API will return 404 for
// missing videos and can be used to check youtube links.
// See https://stackoverflow.com/a/19377429/270334
pattern: Regex::new(r"^(https?://)?(www\.)?(youtube\.com|youtu\.?be)").unwrap(),
rewrite: |request| {
let mut out = request;

View file

@ -53,8 +53,6 @@ mod cli {
}
#[test]
#[ignore]
// Youtube oembed doesn't work at the moment. Getting a 404 instead of a 200
fn test_quirks() {
let mut cmd = main_command();
let test_quirks_path = fixtures_path().join("TEST_QUIRKS.txt");