Hopiu/lychee
1
0
Fork 0
mirror of https://github.com/Hopiu/lychee.git synced 2026-04-22 14:04:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Skip Docker login on PRs from forks (#586)

Browse source 
Since github.repository_owner refers to the base repository on pull request events, while secrets need to exist on the head repository, the Docker Hub login fails for pull requests opened from forks. This commit assures that this step in case of pull request events only runs for internal pull requests, i.e. when head and base repository are the same.

For the actual Docker Hub upload, no change is required: The build can run in every case, the upload is not done on pull request events in general.

Signed-off-by: MichaIng <micha@dietpi.com>
This commit is contained in:
MichaIng 2022-04-06 19:35:28 +02:00 committed by GitHub
parent 0d6f84217f
commit fb4c6d5559
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/docker.yml vendored
View file

@ -51,14 +51,14 @@ jobs:
uses: docker/setup-buildx-action@v1
- name: Login to DockerHub
if: ${{ github.repository_owner == 'lycheeverse' && github.actor != 'dependabot[bot]' }}
if: github.repository_owner == 'lycheeverse' && github.actor != 'dependabot[bot]' && ( github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == github.event.pull_request.base.repo.owner.login )
uses: docker/login-action@v1
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
- name: Push Image
if: ${{ github.repository_owner == 'lycheeverse' }}
if: github.repository_owner == 'lycheeverse'
uses: docker/build-push-action@v2
with:
context: .