Hopiu/micro
1
0
Fork 0
mirror of https://github.com/Hopiu/micro.git synced 2026-03-24 01:40:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix potential file leaks (#1958)

Browse source
This commit is contained in:
Dmitry Maluka 2020-12-23 21:21:01 +01:00 committed by GitHub
parent 2fbeb40bf0
commit e4f7f80862
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
internal/buffer/buffer.go
View file

@ -216,17 +216,18 @@ func NewBufferFromFileAtLoc(path string, btype BufType, cursorLoc Loc) (*Buffer,
readonly := os.IsPermission(err)
f.Close()
file, err := os.Open(filename)
fileInfo, serr := os.Stat(filename)
if serr != nil && !os.IsNotExist(serr) {
return nil, serr
}
if err == nil && fileInfo.IsDir() {
if serr == nil && fileInfo.IsDir() {
return nil, errors.New("Error: " + filename + " is a directory and cannot be opened")
}
defer file.Close()
file, err := os.Open(filename)
if err == nil {
defer file.Close()
}
var buf *Buffer
if os.IsNotExist(err) {