From 4614b5faa4fec451add2cf9d3f298724ed00e6c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20=C5=A0odek?= Date: Wed, 12 Dec 2018 19:09:56 +0100 Subject: [PATCH] Fix diacritics downcoding in slugs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change correctly downcodes diacritics to ASCII if user has WAGTAIL_ALLOW_UNICODE_SLUGS = False (e.g. abčďéfg -> abcdefg) Without this change, the slug simply strips all diacritics which is not ideal (e.g. abčďěfg -> abfg) --- .../wagtail_modeltranslation/js/wagtail_translated_slugs.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wagtail_modeltranslation/static/wagtail_modeltranslation/js/wagtail_translated_slugs.js b/wagtail_modeltranslation/static/wagtail_modeltranslation/js/wagtail_translated_slugs.js index 5b60bd1..80c8e1a 100644 --- a/wagtail_modeltranslation/static/wagtail_modeltranslation/js/wagtail_translated_slugs.js +++ b/wagtail_modeltranslation/static/wagtail_modeltranslation/js/wagtail_translated_slugs.js @@ -8,13 +8,13 @@ $(document).ready(function () { $('#id_title_' + lang_code).on('focus', function () { /* slug should only follow the title field if its value matched the title's value at the time of focus */ var currentSlug = $('#id_slug_' + lang_code).val(); - var slugifiedTitle = cleanForSlug(this.value); + var slugifiedTitle = cleanForSlug(this.value, true); slugFollowsTitle = (currentSlug == slugifiedTitle); }); $('#id_title_' + lang_code).on('keyup keydown keypress blur', function () { if (slugFollowsTitle) { - var slugifiedTitle = cleanForSlug(this.value); + var slugifiedTitle = cleanForSlug(this.value, true); $('#id_slug_' + lang_code).val(slugifiedTitle); } });