Hopiu/wagtail
1
0
Fork 0
mirror of https://github.com/Hopiu/wagtail.git synced 2026-05-11 08:43:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Renamed 'page' argument of page_published signal to 'instance'

Browse source 
This is to give more consistancy with djangos built in signals
This commit is contained in:
Karl Hobley 2014-06-30 14:32:18 +01:00
parent de229914f0
commit 02daf67daf
3 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
wagtail/wagtailadmin/tests/test_pages_views.py
View file

@ -174,9 +174,9 @@ class TestPageCreation(TestCase, WagtailTestUtils):
# Connect a mock signal handler to page_published signal
signal_fired = [False]
signal_page = [None]
def page_published_handler(sender, page, **kwargs):
def page_published_handler(sender, instance, **kwargs):
signal_fired[0] = True
signal_page[0] = page
signal_page[0] = instance
page_published.connect(page_published_handler)
# Post
@ -345,9 +345,9 @@ class TestPageEdit(TestCase, WagtailTestUtils):
# Connect a mock signal handler to page_published signal
signal_fired = [False]
signal_page = [None]
def page_published_handler(sender, page, **kwargs):
def page_published_handler(sender, instance, **kwargs):
signal_fired[0] = True
signal_page[0] = page
signal_page[0] = instance
page_published.connect(page_published_handler)
# Tests publish from edit page
@ -672,9 +672,9 @@ class TestApproveRejectModeration(TestCase, WagtailTestUtils):
# Connect a mock signal handler to page_published signal
signal_fired = [False]
signal_page = [None]
def page_published_handler(sender, page, **kwargs):
def page_published_handler(sender, instance, **kwargs):
signal_fired[0] = True
signal_page[0] = page
signal_page[0] = instance
page_published.connect(page_published_handler)
# Post

6
wagtail/wagtailadmin/views/pages.py
View file

@ -159,7 +159,7 @@ def create(request, content_type_app_name, content_type_model_name, parent_page_
page.save_revision(user=request.user, submitted_for_moderation=is_submitting)
if is_publishing:
page_published.send(sender=page_class, page=page)
page_published.send(sender=page_class, instance=page)
messages.success(request, _("Page '{0}' published.").format(page.title))
elif is_submitting:
messages.success(request, _("Page '{0}' submitted for moderation.").format(page.title))
@ -240,7 +240,7 @@ def edit(request, page_id):
page.save_revision(user=request.user, submitted_for_moderation=is_submitting)
if is_publishing:
page_published.send(sender=page.__class__, page=page)
page_published.send(sender=page.__class__, instance=page)
messages.success(request, _("Page '{0}' published.").format(page.title))
elif is_submitting:
messages.success(request, _("Page '{0}' submitted for moderation.").format(page.title))
@ -609,7 +609,7 @@ def approve_moderation(request, revision_id):
if request.POST:
revision.publish()
page_published.send(sender=revision.page.__class__, page=revision.page.specific)
page_published.send(sender=revision.page.__class__, instance=revision.page.specific)
messages.success(request, _("Page '{0}' published.").format(revision.page.title))
tasks.send_notification.delay(revision.id, 'approved', request.user.id)

2
wagtail/wagtailcore/signals.py
View file

@ -1,4 +1,4 @@
from django.dispatch import Signal
page_published = Signal(providing_args=['page'])
page_published = Signal(providing_args=['instance'])