From 09bc28fc86cfd57a01557dc28b8ffb153244712e Mon Sep 17 00:00:00 2001 From: Loic Teixeira Date: Tue, 31 Jul 2018 17:19:04 -0500 Subject: [PATCH] Remove deprecation warning --- wagtail/core/blocks/field_block.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/wagtail/core/blocks/field_block.py b/wagtail/core/blocks/field_block.py index ea7fd3171..8bda3d101 100644 --- a/wagtail/core/blocks/field_block.py +++ b/wagtail/core/blocks/field_block.py @@ -1,5 +1,4 @@ import datetime -import warnings from django import forms from django.db.models.fields import BLANK_CHOICE_DASH @@ -13,7 +12,6 @@ from django.utils.safestring import mark_safe from wagtail.core.rich_text import RichText from wagtail.core.utils import resolve_model_string -from wagtail.utils.deprecation import RemovedInWagtail24Warning from .base import Block @@ -597,12 +595,10 @@ class ChooserBlock(FieldBlock): class PageChooserBlock(ChooserBlock): def __init__(self, page_type=None, can_choose_root=False, target_model=None, **kwargs): + # We cannot simply deprecate 'target_model' in favour of 'page_type' + # as it would force developers to update their old migrations. + # Mapping the old 'target_model' to the new 'page_type' kwarg instead. if target_model: - warnings.warn( - "PageChooserBlock's `target_model` parameter is deprecated. " - "Please use `page_type` instead.", - category=RemovedInWagtail24Warning - ) page_type = target_model if page_type: