From 09cdc99ff21d794a16034ec7f9f7679efafabfca Mon Sep 17 00:00:00 2001 From: Dave Cranwell Date: Thu, 3 Jul 2014 10:14:01 +0100 Subject: [PATCH] Addressing issue where ordering of new inlinepanel items created two items of the same order --- wagtail/wagtailadmin/static/wagtailadmin/js/page-editor.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/wagtail/wagtailadmin/static/wagtailadmin/js/page-editor.js b/wagtail/wagtailadmin/static/wagtailadmin/js/page-editor.js index 4f76ce8a2..a5dd67eeb 100644 --- a/wagtail/wagtailadmin/static/wagtailadmin/js/page-editor.js +++ b/wagtail/wagtailadmin/static/wagtailadmin/js/page-editor.js @@ -247,7 +247,10 @@ function InlinePanel(opts) { } self.initChildControls(fixPrefix(opts.emptyChildFormPrefix)); if (opts.canOrder) { - $(fixPrefix('#id_' + opts.emptyChildFormPrefix + '-ORDER')).val(formCount); + /* NB form hidden inputs use 0-based index and only increment formCount *after* this function is run. + Therefore formcount and order are currently equal and order must be incremented + to ensure it's *greater* than previous item */ + $(fixPrefix('#id_' + opts.emptyChildFormPrefix + '-ORDER')).val(formCount + 1); } self.updateMoveButtonDisabledStates();