Implemented remaining suggestions from @chosak

This commit is contained in:
Karl Hobley 2017-09-29 12:15:47 +01:00 committed by Matt Westcott
parent 1c13461004
commit 2082c2ff76
2 changed files with 3 additions and 3 deletions

View file

@ -8,7 +8,7 @@
</tr>
</thead>
<tbody>
{% for group in page_obj %}
{% for group in groups %}
<tr>
<td class="title">
<h2>

View file

@ -55,7 +55,7 @@ class SearchableListMixin(object):
search_fields = []
def get_search_form(self):
if 'q' in self.request.GET:
if self.request.GET.get('q'):
return SearchForm(self.request.GET, placeholder=self.search_box_placeholder)
else:
return SearchForm(placeholder=self.search_box_placeholder)
@ -79,7 +79,7 @@ class SearchableListMixin(object):
def get_context_data(self, **kwargs):
if 'search_form' not in kwargs:
kwargs['search_form'] = self.get_search_form()
kwargs['is_searching'] = 'q' in self.request.GET
kwargs['is_searching'] = bool(self.request.GET.get('q'))
return super(SearchableListMixin, self).get_context_data(**kwargs)