Hopiu/wagtail
1
0
Fork 0
mirror of https://github.com/Hopiu/wagtail.git synced 2026-03-26 19:00:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make EmbedBlock tests work offline

Browse source 
As of 42caa586b4 the embed endpoint is checked on EmbedBlock.clean, so we need to mock get_embed during these tests to avoid a live HTTP request.
This commit is contained in:
Matt Westcott 2018-10-26 13:18:40 +02:00 committed by Matt Westcott
parent a671f19298
commit 2dce8bc1c1
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
wagtail/embeds/tests.py
View file

@ -518,7 +518,10 @@ class TestEmbedBlock(TestCase):
self.assertIsInstance(block5.get_default(), EmbedValue)
self.assertEqual(block5.get_default().url, 'http://www.example.com/foo')
def test_clean_required(self):
@patch('wagtail.embeds.embeds.get_embed')
def test_clean_required(self, get_embed):
get_embed.return_value = Embed(html='<h1>Hello world!</h1>')
block = EmbedBlock()
cleaned_value = block.clean(
@ -530,7 +533,10 @@ class TestEmbedBlock(TestCase):
with self.assertRaisesMessage(ValidationError, ''):
block.clean(None)
def test_clean_non_required(self):
@patch('wagtail.embeds.embeds.get_embed')
def test_clean_non_required(self, get_embed):
get_embed.return_value = Embed(html='<h1>Hello world!</h1>')
block = EmbedBlock(required=False)
cleaned_value = block.clean(
@ -542,7 +548,10 @@ class TestEmbedBlock(TestCase):
cleaned_value = block.clean(None)
self.assertIsNone(cleaned_value)
def test_clean_invalid_url(self):
@patch('wagtail.embeds.embeds.get_embed')
def test_clean_invalid_url(self, get_embed):
get_embed.side_effect = EmbedNotFoundException
non_required_block = EmbedBlock(required=False)
with self.assertRaises(ValidationError):