From 430b50424e632e05c23f148346f31ae774265a2b Mon Sep 17 00:00:00 2001 From: jacobtm Date: Wed, 30 Oct 2019 11:58:50 +0000 Subject: [PATCH] Include scss formatting and add bold formatting to locking messages --- client/scss/components/_messages.scss | 12 ++++++++++++ wagtail/admin/views/pages.py | 7 ++++--- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/client/scss/components/_messages.scss b/client/scss/components/_messages.scss index e16768ee4..3d4d48547 100644 --- a/client/scss/components/_messages.scss +++ b/client/scss/components/_messages.scss @@ -74,6 +74,18 @@ .errorlist { margin: 0.5em 0 0 1em; } + + .lock { + &:before { + content: map-get($icons, 'locked'); + } + } + + .unlock { + &:before { + content: map-get($icons, 'unlocked'); + } + } } .messages.new > ul { diff --git a/wagtail/admin/views/pages.py b/wagtail/admin/views/pages.py index 1fda8a7eb..7a709c2e2 100644 --- a/wagtail/admin/views/pages.py +++ b/wagtail/admin/views/pages.py @@ -11,6 +11,7 @@ from django.shortcuts import get_object_or_404, redirect, render from django.template.loader import render_to_string from django.urls import reverse from django.utils import timezone +from django.utils.html import format_html from django.utils.http import is_safe_url, urlquote from django.utils.safestring import mark_safe from django.utils.translation import ugettext as _ @@ -346,12 +347,12 @@ def edit(request, page_id): page_locked = page_perms.page_locked() if user_has_lock: - messages.warning(request, _("Page '{0}' was locked by you on {1}.").format(page.get_admin_display_title(), page.locked_at.strftime("%d %b %Y %H:%M")), extra_tags='lock') + messages.warning(request, format_html(_("Page '{}' was locked by you on {}."), page.get_admin_display_title(), page.locked_at.strftime("%d %b %Y %H:%M")), extra_tags='lock') if page_locked: locked_by_message = "" if page.locked_by: - locked_by_message = " by " + str(page.locked_by) - messages.error(request, _("Page '{0}' was locked{1} on {2}.").format(page.get_admin_display_title(), locked_by_message, page.locked_at.strftime("%d %b %Y %H:%M")), extra_tags='lock') + locked_by_message = format_html(" by {}", str(page.locked_by)) + messages.error(request, format_html(_("Page '{}' was locked{} on {}."), page.get_admin_display_title(), locked_by_message, page.locked_at.strftime("%d %b %Y %H:%M")), extra_tags='lock') next_url = get_valid_next_url_from_request(request)