Hopiu/wagtail
1
0
Fork 0
mirror of https://github.com/Hopiu/wagtail.git synced 2026-03-16 22:10:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "Fix submenu footer blocking items in admin" (#5606)

Browse source 
This change causes the footer to no longer be bottom-aligned when the menu is shorter than window height.

This reverts commit a459e91692.
This commit is contained in:
Matt Westcott 2020-01-17 12:58:20 +00:00
parent 349fca66f3
commit 590bea3b7b
5 changed files with 1 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.txt
View file

@ -24,7 +24,6 @@ Changelog
* Added cache control headers when serving documents (Johannes Vogel)
* Use `sensitive_post_parameters` on password reset form (Dan Braghis)
* Fix: Rename documents listing column 'uploaded' to 'created' (LB (Ben Johnston))
* Fix: Submenu items longer then the page height are no longer broken by the submenu footer (Igor van Spengen)
* Fix: Unbundle the l18n library as it was bundled to avoid installation errors which have been resolved (Matt Westcott)
* Fix: Prevent error when comparing pages that reference a model with a custom primary key (Fidel Ramos)
* Fix: Moved `get_document_model` location so it can be imported when Models are not yet loaded (Andrey Smirnov)

1
CONTRIBUTORS.rst
View file

@ -417,7 +417,6 @@ Contributors
* kailwallin
* ryanomor
* Thijs Baaijen
* Igor van Spengen
* Stefani Castellanos
* Aliosha Padovani
* Tom Readings

9
client/scss/components/_main-nav.scss
View file

@ -388,10 +388,6 @@ body.explorer-open {
width: $menu-width;
}
ul {
position: relative;
}
h2 {
display: block;
padding: 0.2em 0;
@ -413,11 +409,6 @@ body.explorer-open {
.footer {
position: absolute;
&-submenu {
position: sticky;
max-height: unset;
}
}
}

1
docs/releases/2.8.rst
View file

@ -49,7 +49,6 @@ Bug fixes
~~~~~~~~~
* Rename documents listing column 'uploaded' to 'created' (LB (Ben Johnston))
* Submenu items longer then the page height are no longer broken by the submenu footer (Igor van Spengen)
* Unbundle the l18n library as it was bundled to avoid installation errors which have been resolved (Matt Westcott)
* Prevent error when comparing pages that reference a model with a custom primary key (Fidel Ramos)
* Moved ``get_document_model`` location so it can be imported when Models are not yet loaded (Andrey Smirnov)

2
wagtail/admin/templates/wagtailadmin/shared/menu_settings_menu_item.html
View file

@ -2,7 +2,7 @@
{% load wagtailcore_tags %}
{% block menu_footer %}
<li class="footer footer-submenu">
<li class="footer">
<div class="menu-item"><p class="wagtail-version">Wagtail v.{% wagtail_version %}</p></div>
</li>
{% endblock %}