From 8b6f03c732a97cb385ae58ddef4439fa55db27da Mon Sep 17 00:00:00 2001 From: LB Johnston Date: Sun, 17 Mar 2019 20:55:59 +1000 Subject: [PATCH] raise an error in tests if sub-classes of ActionMenuItem has no name --- wagtail/tests/testapp/wagtail_hooks.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/wagtail/tests/testapp/wagtail_hooks.py b/wagtail/tests/testapp/wagtail_hooks.py index 050cc05c6..b1918e657 100644 --- a/wagtail/tests/testapp/wagtail_hooks.py +++ b/wagtail/tests/testapp/wagtail_hooks.py @@ -142,4 +142,10 @@ class RelaxMenuItem(ActionMenuItem): @hooks.register('construct_page_action_menu') def register_relax_menu_item(menu_items, request, context): + # Run a validation check on all core menu items to ensure name attribute is present + names = [(item.__class__.__name__, item.name or '') for item in menu_items] + name_exists_on_all_items = [len(name[1]) > 1 for name in names] + if not all(name_exists_on_all_items): + raise AttributeError('all core sub-classes of ActionMenuItems must have a name attribute', names) + menu_items.append(RelaxMenuItem())