From 9efa3af564054dcc0df8d5e18823d323e2173e7d Mon Sep 17 00:00:00 2001 From: Matt Westcott Date: Tue, 8 Sep 2015 17:50:26 +0100 Subject: [PATCH] Chooser widgets should be considered is_hidden=False --- wagtail/wagtailadmin/tests/test_widgets.py | 4 ++++ wagtail/wagtailadmin/widgets.py | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/wagtail/wagtailadmin/tests/test_widgets.py b/wagtail/wagtailadmin/tests/test_widgets.py index 62b366395..00b18961c 100644 --- a/wagtail/wagtailadmin/tests/test_widgets.py +++ b/wagtail/wagtailadmin/tests/test_widgets.py @@ -18,6 +18,10 @@ class TestAdminPageChooserWidget(TestCase): ) self.root_page.add_child(instance=self.child_page) + def test_not_hidden(self): + widget = widgets.AdminPageChooser() + self.assertFalse(widget.is_hidden) + def test_render_html(self): widget = widgets.AdminPageChooser() diff --git a/wagtail/wagtailadmin/widgets.py b/wagtail/wagtailadmin/widgets.py index 15645cd5c..617214c1f 100644 --- a/wagtail/wagtailadmin/widgets.py +++ b/wagtail/wagtailadmin/widgets.py @@ -68,6 +68,10 @@ class AdminChooser(WidgetWithScript, widgets.Input): link_to_chosen_text = _("Edit this item") show_edit_link = True + # when looping over form fields, this one should appear in visible_fields, not hidden_fields + # despite the underlying input being type="hidden" + is_hidden = False + def get_instance(self, model_class, value): # helper method for cleanly turning 'value' into an instance object if value is None: