From ada810cce33cca363ce4b1fe9e57ac6f3a358c07 Mon Sep 17 00:00:00 2001 From: Karl Hobley Date: Thu, 8 Oct 2015 21:00:00 +0100 Subject: [PATCH] cleanup(api/2): No longer need "show_details" --- wagtail/api/v2/endpoints.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/wagtail/api/v2/endpoints.py b/wagtail/api/v2/endpoints.py index f140aad6c..84a4efc3f 100644 --- a/wagtail/api/v2/endpoints.py +++ b/wagtail/api/v2/endpoints.py @@ -140,7 +140,7 @@ class BaseAPIEndpoint(GenericViewSet): fields = ['id', 'meta'] + fields # If showing details, add the parent field - if isinstance(self, PagesAPIEndpoint) and self.get_serializer_context().get('show_details', False): + if isinstance(self, PagesAPIEndpoint) and self.action == 'detail_view': fields.insert(2, 'parent') return get_serializer_class(model, fields, base=self.base_serializer_class) @@ -149,17 +149,12 @@ class BaseAPIEndpoint(GenericViewSet): """ The serialization context differs between listing and detail views. """ - context = { + return { 'request': self.request, 'view': self, 'router': self.request.wagtailapi_router } - if self.action == 'detail_view': - context['show_details'] = True - - return context - def get_renderer_context(self): context = super(BaseAPIEndpoint, self).get_renderer_context() context['indent'] = 4