Hopiu/wagtail
1
0
Fork 0
mirror of https://github.com/Hopiu/wagtail.git synced 2026-05-27 08:04:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add labels to snippet bulk edit checkboxes for screen reader users. Fix #5328 (#5463)

Browse source
This commit is contained in:
Martey Dodoo 2019-08-05 13:12:08 -04:00 committed by Thibaud Colas
parent 6bc94ee56d
commit bb4e2fe2df
3 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.txt
View file

@ -12,6 +12,7 @@ Changelog
* Fix: Changed StreamField group labels color so labels are visible (Catherine Farman) * Fix: Changed StreamField group labels color so labels are visible (Catherine Farman)
* Fix: Prevented images with a very wide aspect ratio from being displayed distorted in the rich text editor (Iman Syed) * Fix: Prevented images with a very wide aspect ratio from being displayed distorted in the rich text editor (Iman Syed)
* Fix: Prevent exception when deleting a model with a protected One-to-one relationship (Neal Todd) * Fix: Prevent exception when deleting a model with a protected One-to-one relationship (Neal Todd)
* Fix: Added labels to snippet bulk edit checkboxes for screen reader users (Martey Dodoo)
2.6.1 (05.08.2019) 2.6.1 (05.08.2019)

1
docs/releases/2.7.rst
View file

@ -30,6 +30,7 @@ Bug fixes
* Changed StreamField group label color so labels are visible (Catherine Farman) * Changed StreamField group label color so labels are visible (Catherine Farman)
* Prevented images with a very wide aspect ratio from being displayed distorted in the rich text editor (Iman Syed) * Prevented images with a very wide aspect ratio from being displayed distorted in the rich text editor (Iman Syed)
* Prevent exception when deleting a model with a protected One-to-one relationship (Neal Todd) * Prevent exception when deleting a model with a protected One-to-one relationship (Neal Todd)
* Added labels to snippet bulk edit checkboxes for screen reader users (Martey Dodoo)
Upgrade considerations Upgrade considerations

12
wagtail/snippets/templates/wagtailsnippets/snippets/list.html
View file

@ -6,7 +6,12 @@
<col width="16%" /> <col width="16%" />
<thead> <thead>
<tr class="table-headers"> <tr class="table-headers">
{% if can_delete_snippets %}<th><input type="checkbox" class="toggle-select-all"/></th>{% endif %} {% if can_delete_snippets %}
<th>
<input type="checkbox" class="toggle-select-all" id="toggle-select-all-snippets" />
<label for="toggle-select-all-snippets" class="visuallyhidden">{% blocktrans with snippet_type_name_plural=model_opts.verbose_name_plural %}Select all {{ snippet_type_name_plural }}{% endblocktrans %}</label>
</th>
{% endif %}
<th>{% trans "Title" %}</th> <th>{% trans "Title" %}</th>
</tr> </tr>
</thead> </thead>
@ -14,7 +19,10 @@
{% for snippet in items %} {% for snippet in items %}
<tr id="snippet-row-{{ snippet.pk }}"> <tr id="snippet-row-{{ snippet.pk }}">
{% if can_delete_snippets %} {% if can_delete_snippets %}
<td class="select"><input type="checkbox" name="select_snippet" value="{{ snippet.pk }}" class="toggle-select-row"/></td> <td class="select">
<input type="checkbox" name="select_snippet" id="select-snippet-{{ snippet.pk }}" value="{{ snippet.pk }}" class="toggle-select-row"/>
<label for="select-snippet-{{ snippet.pk }}" class="visuallyhidden">{% blocktrans %}Select {{ snippet }}{% endblocktrans %}</label>
</td>
{% endif %} {% endif %}
<td class="title"> <td class="title">
{% if choosing %} {% if choosing %}