Clean up W293 errors

This commit is contained in:
Karl Hobley 2015-04-03 17:15:22 +01:00
parent 01808528db
commit c63b585d8c
11 changed files with 13 additions and 15 deletions

View file

@ -10,7 +10,6 @@ from wagtail.wagtailimages.widgets import AdminImageChooser
from wagtail.wagtaildocs.widgets import AdminDocumentChooser
class ExampleForm(forms.Form):
def __init__(self, *args, **kwargs):
super(ExampleForm, self).__init__(*args, **kwargs)
self.fields['page_chooser'].widget = AdminPageChooser()

View file

@ -724,11 +724,10 @@ Page.settings_panels = [
class BaseStreamFieldPanel(BaseFieldPanel):
def classes(self):
classes = super(BaseStreamFieldPanel, self).classes()
classes.append("stream-field")
# BaseFieldPanel is essentially for single fields, which are rendered on the front end
# with the assumption that the label (singular) will always be promoted to the full-width
# divider bar thing.

View file

@ -13,7 +13,7 @@ register = template.Library()
def wagtailuserbar(context):
# Find request object
request = context['request']
# Don't render if user doesn't have permission to access the admin area
if not request.user.has_perm('wagtailadmin.access_admin'):
return ''

View file

@ -44,7 +44,7 @@ class EditPageItem(BaseItem):
# Don't render if user doesn't have permission to access the admin area
if not request.user.has_perm('wagtailadmin.access_admin'):
return ""
# Don't render if the user doesn't have permission to edit this page
permission_checker = self.page.permissions_for_user(request.user)
if not permission_checker.can_edit():
@ -69,7 +69,7 @@ class ModeratePageItem(BaseItem):
if not self.revision.page.permissions_for_user(request.user).can_publish():
return ""
return super(ModeratePageItem, self).render(request)
class ApproveModerationEditPageItem(ModeratePageItem):

View file

@ -74,7 +74,7 @@ def send_mail(email_subject, email_content, email_addresses, from_email=None):
def send_notification(page_revision_id, notification, excluded_user_id):
# Get revision
revision = PageRevision.objects.get(id=page_revision_id)
# Get list of recipients
if notification == 'submitted':
# Get list of publishers

View file

@ -11,7 +11,7 @@ from django.db.migrations.autodetector import MigrationAutodetector
from django.db.migrations.state import ProjectState
from django.db.migrations.questioner import MigrationQuestioner
class TestForMigrations(TransactionTestCase):
def test__migrations(self):
app_labels = set(app.label for app in apps.get_app_configs()

View file

@ -292,7 +292,7 @@ OEMBED_ENDPOINTS = {
"http://www.ifttt.com/oembed/": [
"^http(?:s)?://ifttt\\.com/recipes/.+$"
],
# Added 11th December 2014 - http://developers.issuu.com/api/oembed.html
"http://issuu.com/oembed": [
"^http(?:s)?://(?:www\\.)?issuu\\.com/[^#?/]+/docs/.+$"

View file

@ -79,7 +79,7 @@ class ImageOperationTestCase(unittest.TestCase):
test_name = 'test_run_%s' % filter_spec
test_run.__name__ = test_name
return test_run
@classmethod
def setup_test_methods(cls):
if cls.operation_class is None:

View file

@ -66,7 +66,7 @@ def add(request):
}, {
'file': request.FILES['files[]'],
})
if form.is_valid():
# Save it
image = form.save(commit=False)

View file

@ -96,7 +96,7 @@ class TestRedirectsAddView(TestCase, WagtailTestUtils):
def get(self, params={}):
return self.client.get(reverse('wagtailredirects_add_redirect'), params)
def post(self, post_data={}):
return self.client.post(reverse('wagtailredirects_add_redirect'), post_data)
@ -142,7 +142,7 @@ class TestRedirectsEditView(TestCase, WagtailTestUtils):
def get(self, params={}, redirect_id=None):
return self.client.get(reverse('wagtailredirects_edit_redirect', args=(redirect_id or self.redirect.id, )), params)
def post(self, post_data={}, redirect_id=None):
return self.client.post(reverse('wagtailredirects_edit_redirect', args=(redirect_id or self.redirect.id, )), post_data)
@ -190,7 +190,7 @@ class TestRedirectsDeleteView(TestCase, WagtailTestUtils):
def get(self, params={}, redirect_id=None):
return self.client.get(reverse('wagtailredirects_delete_redirect', args=(redirect_id or self.redirect.id, )), params)
def post(self, post_data={}, redirect_id=None):
return self.client.post(reverse('wagtailredirects_delete_redirect', args=(redirect_id or self.redirect.id, )), post_data)

View file

@ -10,7 +10,7 @@ from wagtail.wagtailadmin.widgets import AdminChooser
class AdminSnippetChooser(AdminChooser):
target_content_type = None
def __init__(self, content_type=None, **kwargs):
if 'snippet_type_name' in kwargs:
snippet_type_name = kwargs.pop('snippet_type_name')