diff --git a/CONTRIBUTORS.rst b/CONTRIBUTORS.rst index fcba8d2d7..df81741c9 100644 --- a/CONTRIBUTORS.rst +++ b/CONTRIBUTORS.rst @@ -29,6 +29,7 @@ Contributors * Tom Talbot * Jeffrey Hearn * Robert Clark +* Tim Heap Translators =========== diff --git a/wagtail/wagtailembeds/embeds.py b/wagtail/wagtailembeds/embeds.py index 03029a23b..2ec974d8a 100644 --- a/wagtail/wagtailembeds/embeds.py +++ b/wagtail/wagtailembeds/embeds.py @@ -162,6 +162,10 @@ def get_embed(url, max_width=None, finder=None): except (TypeError, ValueError): embed_dict['height'] = None + # Make sure html field is valid + if 'html' not in embed_dict or not embed_dict['html']: + embed_dict['html'] = '' + # Create database record embed, created = Embed.objects.get_or_create( url=url, diff --git a/wagtail/wagtailembeds/tests.py b/wagtail/wagtailembeds/tests.py index 8cedf944b..7049f50f4 100644 --- a/wagtail/wagtailembeds/tests.py +++ b/wagtail/wagtailembeds/tests.py @@ -81,6 +81,19 @@ class TestEmbeds(TestCase): # Width must be set to None self.assertEqual(embed.width, None) + def test_no_html(self) : + def no_html_finder(url, max_width=None): + """ + A finder which returns everything but HTML + """ + embed = self.dummy_finder(url, max_width) + embed['html'] = None + return embed + + embed = get_embed('www.test.com/1234', max_width=400, finder=no_html_finder) + + self.assertEqual(embed.html, '') + class TestChooser(TestCase, WagtailTestUtils): def setUp(self): diff --git a/wagtail/wagtailsearch/views/editorspicks.py b/wagtail/wagtailsearch/views/editorspicks.py index bb39c02ba..8e1155922 100644 --- a/wagtail/wagtailsearch/views/editorspicks.py +++ b/wagtail/wagtailsearch/views/editorspicks.py @@ -13,6 +13,7 @@ from wagtail.wagtailadmin.forms import SearchForm @permission_required('wagtailadmin.access_admin') @vary_on_headers('X-Requested-With') def index(request): + is_searching = False page = request.GET.get('p', 1) query_string = request.GET.get('q', "") @@ -21,6 +22,7 @@ def index(request): # Search if query_string: queries = queries.filter(query_string__icontains=query_string) + is_searching = True # Pagination paginator = Paginator(queries, 20) @@ -33,11 +35,13 @@ def index(request): if request.is_ajax(): return render(request, "wagtailsearch/editorspicks/results.html", { + 'is_searching': is_searching, 'queries': queries, 'query_string': query_string, }) else: return render(request, 'wagtailsearch/editorspicks/index.html', { + 'is_searching': is_searching, 'queries': queries, 'query_string': query_string, 'search_form': SearchForm(data=dict(q=query_string) if query_string else None, placeholder=_("Search editor's picks")),