Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-16 23:30:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix($$urlUtils): use document instead of $document

Browse source
This commit is contained in:
Chirayu Krishnappa 2013-07-23 17:19:56 -07:00
parent 7e49d37a98
commit 0a3ec5f8bb
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/ng/urlUtils.js
View file

@ -1,13 +1,15 @@
'use strict';
function $$UrlUtilsProvider() {
this.$get = ['$document', function($document) {
var urlParsingNode = $document[0].createElement("a"),
// NOTE: The usage of window instead of $window here is deliberate. When the browser
// resolves a URL for XHR, it doesn't know about any mocked $window. $$urlUtils
// resolves URLs just as the browser would. Using $window here would confuse the
// isSameOrigin check causing unexpected failures. We avoid that by using the real window
// object.
this.$get = [function() {
var urlParsingNode = document.createElement("a"),
// NOTE: The usage of window and document instead of $window and $document here is
// deliberate. This service depends on the specific behavior of anchor nodes created by the
// browser (resolving and parsing URLs) that is unlikely to be provided by mock objects and
// cause us to break tests. In addition, when the browser resolves a URL for XHR, it
// doesn't know about mocked locations and resolves URLs to the real document - which is
// exactly the behavior needed here. There is little value is mocking these our for this
// service.
originUrl = resolve(window.location.href, true);
/**