Commit graph

2813 commits

Author SHA1 Message Date
Pete Bacon Darwin
116fac0562 docs(guide/controller): improve guidance and examples
Remove mention of global controller functions
Convert larger examples to runnable demos
Remove mention of pre-1.0 controllers, in particular discussion of
controller inheritance.

TODO: Probably could do with updating to explain the "controller as" syntax
at some point.

Closes: #4373
2013-10-11 12:59:39 +01:00
Felix
c3024254b6 docs(guide/controller): use .controller syntax
Use the recommended `module.controller` syntax rather than global
functions to define controllers in the examples.
2013-10-11 12:58:22 +01:00
Pete Bacon Darwin
770353df19 docs($provide): improve docs and examples further
Improve the "tracking" service example by adding a configuration option.
Get better formatting of the generated code samples using <pre> tags.
Move the detailed explanations into each function's documentation block.
Improve the overview and list the constituent functions by significance.

Closes #4302
2013-10-10 18:22:52 +01:00
Tim Ruffles
85b7d24357 docs($provide): improve examples and explanations
$provide's example seems awkward. Replace with more real-world example,
using an injected service, where the service defined has a good reason to
be a singleton.

There's quite a lot of confusion around $provide:
http://stackoverflow.com/search?q=angularjs+service+vs+factory
Tests for example at: http://jsbin.com/EMabAv/1/edit?js,output
2013-10-10 18:22:51 +01:00
Marko Bonaci
8469779a8e docs(tutorial/step11): correct Jasmine Matcher link
Link http://pivotal.github.com/jasmine/jsdoc/symbols/jasmine.Matchers.html
is no longer valid.

Closes #4329
2013-10-09 11:30:47 +01:00
Brian Ford
3374e35953 docs(ngValue): add docs for ngValue directive
Closes #4267
2013-10-07 14:42:54 +01:00
Dave Peticolas
90ff8a98d8 docs(ngModel): fix grammar and improve clarity
Closes #4291

Conflicts:
	src/ng/directive/input.js
2013-10-07 14:41:08 +01:00
Joe Hanink
a4dc21ebf5 docs(angular.bind): clarify that bind is partial application
The `angular.bind` function reflects the definition of "partial application", which
reduces a function's arity rather than transforming a function with n args into a
chain of n functions, each having a single arg.

curry : f(x,y,z) -> f(x)(y)(z)
partial application : f(x,y,z) -> f(x)(y,z)

Closes #4239
2013-10-03 23:46:24 +01:00
mtaran-google
ec93f94cc9 docs(guide/directive): fix indentation in example code
Closes #4241
2013-10-03 23:45:36 +01:00
gdennie
7665497a53 docs(guide/directive): clarify use of binding to scopes
The use of 'angular' as sample text is confusing to the newbie in that they are forced
to confirm that the text 'angular' is not a keyword or otherwise referring to a system
component. This is changed to a more obvious sample text.

The most common form of `ngBind` is moved to the top of the list.

Closes #4237
2013-10-03 23:44:54 +01:00
Pete Bacon Darwin
2acadc4216 docs(rootScope): improve grammar and clarity 2013-10-03 23:18:45 +01:00
paolo-delmundo
c7658d9457 fix($sanitize): sanitize DOCTYPE declarations correctly
HTML to be sanitized that contains a DOCTYPE declaration were causing
the HTML parser to throw an error.  Now the parser correctly removes
the declarations when sanitizing HTML.

Closes #3931
2013-10-03 08:43:06 +01:00
Uri Goldshtein
b92c650e05 docs(angular.copy): add an example with the two possible arguments
Closes #4179
2013-09-30 22:16:30 +01:00
Richard Sentino
f7a0f9d841 docs(tutorial/step0): fix minor typo
Closes #4154
2013-09-30 21:42:37 +01:00
Uri Goldshtein
b17d40b4a5 docs($timeout): add a $timeout example
The original example is by gxlcl.

Closes #4180
2013-09-28 15:26:36 +01:00
Thomas Tuts
d745df7e5f docs(guide/overview): fix typo
Closes #4188
2013-09-28 15:05:43 +01:00
joscarsson
53b444419c docs(guide/e2e-testing): select also uses ng-model (like input)
This is specified for input fields, but not for selects. This change specifies it also for select().
2013-09-27 16:24:17 -07:00
David Bennett
9a21050b43 docs(angular.Module): fix controller and directive method parameters 2013-09-27 16:11:42 -07:00
Dave Peticolas
8473b9d558 docs(ngCsp): fix grammar 2013-09-27 13:14:23 -07:00
Dave Peticolas
679d418a50 docs(dblClick): fix grammar 2013-09-27 13:07:01 -07:00
Dave Peticolas
16d247b386 docs(ngDisabled): clarify 2013-09-27 13:06:13 -07:00
Misha Moroshko
4767d34ae8 docs(docs.css): prevent <code> elements from wrapping
Closes #4114
2013-09-25 22:39:37 +01:00
Dave Peticolas
5efc2ed5ac docs(ngHref): fix formatting and clarify
Closes #4106
2013-09-25 22:33:13 +01:00
lorint
f9bf194439 docs(jqLite): fix typo
Closes #4105
2013-09-25 22:31:19 +01:00
gdennie
3c4460b513 docs(guide/$location): provide a title for section about replace()
Closes #4104
2013-09-25 22:30:10 +01:00
gdennie
a98931de0e docs(guide/$location): clarify $location service role
Clean up confusing use of the term URL to refer to $location as well as 'URL in the browser'.

Closes #4103
2013-09-25 22:27:43 +01:00
Mr.Raindrop
7e5154e755 docs($http): fix adding default header to get request example
Initially, `$httpProvider.defaults.headers.get` is `undefined`, so
`$httpProvider.defaults.headers.get['My-Header']='value'` will throw an
error.

Closes #4101
2013-09-25 22:27:33 +01:00
janhartigan
ec6b1cfaba docs(guide/e2e-testing): Fix typo
Closes #4100
2013-09-25 22:27:06 +01:00
Pete Bacon Darwin
8d8801f1ae fix(ngScenario): fix error message description 2013-09-25 12:43:03 +01:00
Boris Serdyuk
301647bf1b refactor(angular.toJson): use charAt instead of regexp
Provides a performance improvement when serializing to JSON strings.

Closes #4093
2013-09-23 11:16:33 +01:00
Pete Bacon Darwin
1c03a1b9c0 docs(ngModelController): clarify issue with isolated scope directive
See #4043
2013-09-19 21:09:20 +01:00
ts-web
fd797cdb7e docs(input): fix spelling error and reword for clarity 2013-09-19 21:09:20 +01:00
Dave Peticolas
ed1dbf2554 doc(ngApp): fix grammar 2013-09-19 20:17:49 +01:00
Jared Forsyth
022cb3dc4e docs($exceptionHandler): add an example of overriding the handler
Closes #3816
2013-09-19 14:51:50 +01:00
Maarten Stolte
4f107acfcf docs(guide/i18n): change non-existent de-ge to de-de
The de-ge locale does not exist

Closes #4053
2013-09-19 11:27:20 +01:00
Dave Peticolas
f363bcb437 docs(ngForm): fix grammar and improve explanation
Closes #4050
2013-09-19 10:41:30 +01:00
Ash
7b2259f32c docs(guide/$location): describe workaround for collocated apps
When using Angular in the root of a domain with HTML5 URLs
where there are links to external paths within the same directory,
the `otherwise` route handler will catch these external files.
This can be fixed by prefixing '.' onto the links to URLs that should
be handled by angular routing.

Original Issue: #3520
Example of Fix: http://fiddle.jshell.net/fgHf6/3/

Closes #3555
2013-09-18 14:34:39 +01:00
Zachary Friedman
9e88fa18b9 docs(tutorial/step_03): add info about karma-ng-scenario plug-in
The existing documentation for this step could have people find themselves
unable to run the `e2e-test.sh` script. This note added regarding
`karma-ng-scenario` will minimize their confusion and allow people to run
the script.

Closes #4033
2013-09-18 12:45:05 +01:00
Hubert SABLONNIÈRE
094580c3da fix(scenario): include "not " in error messages if test is inverted
Closes #3840
2013-09-18 12:34:25 +01:00
James
cc4d08c5f0 docs(input): clarify that contenteditable is an HTML5 attribute
Closes #3841
2013-09-17 11:44:04 +01:00
Jesse Palmer
d0ae241afd docs(orderBy): fix typo in orderBy.js documentation
Closes #3838
2013-09-16 22:29:25 +01:00
Dave Peticolas
e1f103a8e4 doc(api): fix grammar in a directive description
- Add missing words.
- Simplify text.
2013-09-16 16:36:19 +01:00
Dave Peticolas
d17aa84be1 docs(api): fix grammar in ngClick description
- Add missing word 'directive'.
- Add missing word 'an'.
2013-09-16 16:33:51 +01:00
Ben Tesser
e87c88914f docs($browser): add jsdoc tags and fix typo 2013-09-13 21:37:51 +01:00
Dean Sofer
b5d48ee1f0 docs(ngController): rephrased the description for clarity 2013-09-13 14:27:26 +01:00
Pete Bacon Darwin
1c010b33aa docs($http): add examples when calling $http outside $apply
Closes #3996
2013-09-13 14:20:14 +01:00
Dang Nguyen Anh Khoa
16c7ab1ba0 docs($http): explain why $http may not make the request immediately
I came across this issue today and after researching has found out this thread on so:
http://stackoverflow.com/questions/17039998/angular-not-making-http-requests-immediately.

It took me quite sometimes to figure out this so I hope the addition in documentation could save somebody else some times and frustration.
2013-09-13 14:20:14 +01:00
Gowtam Lal
9ef5d8f318 fix(ngOptions): ignore object properties which start with $ 2013-09-13 13:22:36 +01:00
brakon
6a634e309b docs(guide/e2e_testing): clarify that .enter searches by ng-model 2013-09-13 12:34:40 +01:00
Woody Peterson
13f58447e2 test($browser): correct false positive in ApplicationSpec.js
Previously, the check that Application should return a new $window and
$document had the arguments reversed in the first call to navigateTo;
thus, the subsequent check of inequality of $window and $document in the
next navigateTo call would always pass.

This corrects the argument order, which makes this test not succeptible
to false positives.
2013-09-11 22:21:12 +01:00