Commit graph

149 commits

Author SHA1 Message Date
Eric Eldredge
fe2fb844af Changed the way post_save and post_delete signals are being handled.
One handler is created per model instead of per bound image spec.
This cuts down on the number of handlers created, and also offloads the
policing of the handlers in memory to the signal framework. Since they are no
longer being created per spec, the handlers can be weakly referenced.
2011-09-21 10:44:05 -04:00
Eric Eldredge
b1c5432310 Implemented post_save and post_delete handlers for ImageSpecs.
Removed the save and clear_cache methods from ImageModel (along with helpers).
Now, whenever an ImageSpec is contributed to a model, handlers are created for
the post_save and post_delete signals. The post_save handler does the work of
running the ImageSpec processors and caching the resulting file, while the
post_delete handler does the work cleaning up the cached files.
2011-09-21 09:56:27 -04:00
Matthew Tretter
34e475885b Unbound fields are accessible from class. 2011-09-21 09:52:38 -04:00
Matthew Tretter
2770be23ea Naming & implementation of bound fields are more consistent.
Bound fields are now named as such (BoundBlah), extend their unbound
counterparts, and their constructors accept an unbound instance.
2011-09-21 09:39:06 -04:00
Matthew Tretter
a71b3ca337 Removed Format processor
The Format processor was really a special case and didn't do any
processing at all. Instead, ImageSpec just knew to look for it and
responded accordingly. Therefore, it's been replaced with a `format`
property on ImageSpec. This warranted a deeper look at how the format
and extension were being deduced (when not explicitly provided); the
results are documented in-code, though the goal was "no surprises."
2011-09-20 21:34:00 -04:00
Matthew Tretter
80c785f2e5 No need for this. 2011-09-20 21:03:34 -04:00
Matthew Tretter
544d5b874a Added AdminThumbnailView field.
You're no longer restricted to just one, special-case admin thumbnail. Make as
many as you want by adding AdminThumbnailView properties to your model and
including them in your admin class's `list_display` tuple. You can also provide
a custom template. Note that (because this change introduces templates to
imagekit), imagekit is now required in INSTALLED_APPS.

Ideally we could get this stuff out of the model, but we'll have to look into
whether that's possible without making things really complicated.
2011-09-20 19:37:04 -04:00
Matthew Tretter
501d3c7ad3 Now using contribute_to_class.
By creating the Descriptor using contribute_to_class (instead of in
ImageModelBase's __init__), we take the first step towards eliminating the need
to extend ImageModel at all.
2011-09-20 15:44:54 -04:00
Matthew Tretter
82348d4931 Changed how cache files are named.
Removed the cache_dir, cache_filename_fields and cache_filename_format
properties of IKOptions. While these were very powerful, I felt that it was
unnecessarily confusing to have two properties (cache_dir and
cache_filename_format) that determine the filename. The new cache_to property is
modeled after ImageField's upload_to and behaves almost identically (the only
exception being that a callable value receives different arguments). In
addition, I felt that the interpolation of model properties provided by
cache_filename_fields, though useful, would be better handled by a utility
function outside of this library.
2011-09-18 21:08:49 -04:00
Matthew Tretter
8cfe485a5a Storage can be specified on a per-spec basis.
If not defined on the spec, IKOptions.default_storage will be used. If that's
not defined, it will fall back to the image field's storage.
2011-09-10 00:25:34 -04:00
Matthew Tretter
57a28091c5 Added default_image_field
This works kind of like Django's models' _default_manager. If your specs don't
specify an image_field, and your IKOptions don't specify a default_image_field,
the first ImageField your model defines will be used.
2011-09-10 00:25:27 -04:00
Matthew Tretter
4c78f2d24c _imgfield is now a property of ImageSpec
Moved _imgfield from ImageModel to ImageSpec. Theoretically, this will allow you
to have specs that use different image fields on the same model.
2011-09-10 00:24:37 -04:00
Matthew Tretter
5e00de5204 Admin thumbnails. 2011-09-10 00:23:47 -04:00
Matthew Tretter
a1f11facbe Processors now use static properties. 2011-09-08 16:49:44 -04:00
Matthew Tretter
db4d704f71 Changed ImageSpec constructor so you can use static properties.
For example:

    class MyImageSpec(ImageSpec):
        quality = 100

    class Photo(ImageModel):
        display = MyImageSpec()
2011-09-08 16:48:53 -04:00
Matthew Tretter
0b0942921b Updated README to reflect the new API. 2011-09-08 15:52:03 -04:00
Matthew Tretter
def8dea23f Storage moved onto ImageSpec. 2011-09-08 10:28:54 -04:00
Matthew Tretter
e32ccb617d Resize split into Crop and Fit. 2011-09-08 10:28:54 -04:00
Matthew Tretter
cd3395b68f Processors are now instance-based. 2011-09-08 10:28:50 -04:00
Matthew Tretter
a9895f335a Using spec properties from ImageModel. 2011-09-08 10:00:22 -04:00
Matthew Tretter
2387cc4be2 Added ability to specify specs in IKOptions directly. 2011-09-02 23:35:58 -04:00
Bryan Veloso
14ef6633b9 Merge pull request #24 from mkai/develop
Minor improvement to fault tolerance of Accessor._delete()
2011-08-26 11:52:49 -07:00
Markus Kaiserswerth
3e3302c7f7 Improve fault tolerance of Accessor._delete()
Handle/ ignored NotImplementedError and IOError which might get thrown
by the storage backend on delete.
2011-08-26 16:42:14 +02:00
Bryan Veloso
4a1d1d9715 Merge pull request #22 from Bers/patch-1
fix issue #12
2011-07-10 18:18:55 -07:00
Bers
aa348d76f6 fix issue #12 2011-07-04 04:09:31 -07:00
Bryan Veloso
2316646563 Merge pull request #21 from kennethreitz/patch-1
proper python comments in readme
2011-06-29 12:32:44 -07:00
Kenneth Reitz
9592edb186 proper python comments in readme 2011-06-29 07:30:51 -07:00
Bryan Veloso
d1e1e67d4f Adding Josh to the contributors list. 2011-06-28 11:40:29 -07:00
Bryan Veloso
4f904cda87 Being a good PyPI citizen. 2011-06-28 11:38:42 -07:00
Greg Newman
5ba04d0976 Merge pull request #20 from joshourisman/develop
Allow any field on the model to be used in the name of the generated images.
2011-06-28 11:33:23 -07:00
Greg Newman
db142eb23f Merge pull request #19 from joshourisman/develop
Allow the PK of an object to be used in the filename of images generated.
2011-06-28 11:27:56 -07:00
Josh Ourisman
5976a512e6 allowing any fields on the object to be specified for use in naming of generated images; default to allowing pk 2011-06-28 14:27:47 -04:00
Josh Ourisman
9845befd96 Added the pk of the object into the dictionary of values passed to the string formatting for cache_filename. 2011-06-28 11:08:05 -07:00
Bryan Veloso
1f882d6fa6 Merge pull request #18 from bchhun/develop
Minor Readme file modification
2011-06-18 21:48:36 -07:00
Bernard Chhun
3bf844687d Added the quality property in the readme's ImageSpec classes just to show it is possible to change it at will. 2011-06-18 15:55:00 -07:00
Bryan Veloso
25f628de93 Merge pull request #17 from Shanto/develop
Fixes: CMYK files from Photoshop fails to load with exception -2
2011-06-17 13:50:44 -07:00
Shanto
6b1aff64c2 Fixes: CMYK files from Photoshop fails to load with exception -2 2011-06-17 13:13:20 -07:00
Bryan Veloso
be28b0dffe Merge branch 'release/0.3.6' into develop
* release/0.3.6:
  Bumping the verison numbers.
2011-04-01 11:59:27 -07:00
Bryan Veloso
9637a43551 Bumping the verison numbers. 2011-04-01 11:56:44 -07:00
Bryan Veloso
f777c08b17 Whitespacing. 2011-03-26 00:46:17 -07:00
Bryan Veloso
c61a6bc640 Adding Jonathan Slenders to AUTHORS (thanks for spotting that signals bug). 2011-03-26 00:42:37 -07:00
Jonathan Slenders
57ef4748b9 fixed 'sender' not defined bug (2) 2011-03-26 15:40:22 +08:00
Jonathan Slenders
53cddf7752 fixed 'sender' not defined bug 2011-03-26 15:40:21 +08:00
Bryan Veloso
ad3f15ef76 Instead of overriding Model.delete(), we'll connect a public clear_cache() method to a post_delete() signal so that bulk actions clean props as well. 2011-02-23 12:54:09 -08:00
Bryan Veloso
ede86f7faa Merge branch 'release/0.3.5' into develop
* release/0.3.5:
  One really should be able to add multiple maintainers.
  Bumping the version number.
2011-02-12 14:05:34 -08:00
Bryan Veloso
9fa53856dc One really should be able to add multiple maintainers. 2011-02-12 14:05:15 -08:00
Bryan Veloso
1b29437180 Bumping the version number. 2011-02-12 14:04:42 -08:00
Bryan Veloso
c566378764 Accessor._delete() and Accessor._exists() needed conditionalizing as well. ikflush was yelling at me. 2011-02-13 05:52:07 +08:00
Bryan Veloso
9c0ff80185 Merge branch 'release/0.3.4' into develop
* release/0.3.4:
  Adding distutils stuff to .gitignore.
  Bumping internal version to 0.3.4.
2011-02-11 12:59:51 -08:00
Bryan Veloso
12bc6fa566 Adding distutils stuff to .gitignore. 2011-02-11 12:59:24 -08:00