Hopiu/jquery-mobile
1
0
Fork 0
mirror of https://github.com/Hopiu/jquery-mobile.git synced 2026-05-13 17:13:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
2082 commits 17 branches 12 tags 110 MiB
Commit graph

930 commits

Author SHA1 Message Date
scottjehl
fbb2fc2c60 lengthened timer for Android, and added a check to let through the same event type for double-taps. 2011-01-21 18:29:28 -05:00
scottjehl
aa0a61c407 followup on previous commit. made sure devices with both touch and mouse events work with either input type. Also fixed regression with radio inputs. 2011-01-21 18:13:02 -05:00
scottjehl
38c1c24e5d moved check/uncheck event on label to touchend/mouseup. Fixes #753 2011-01-21 17:45:22 -05:00
scottjehl
a1cb31a2c7 navbar removes active state but doesn't apply new one. Now it does. Useful in js-generated links. Fixes #669 2011-01-21 16:20:33 -05:00
scottjehl
37f9680c0f only the first image should be an icon/thumb. Fixes #699 2011-01-21 15:33:40 -05:00
John Bender
e5d2bf1b66 added target check to $.mobile.isExternalLink 2011-01-20 23:05:37 -08:00
John Bender
ffafa78e62 added tests for external links in dialogs, small refactor for dialogClickHandler function 2011-01-20 22:20:16 -08:00
scottjehl
52f86f2f9a make sure first textnode of li is used in listview title, regardless of newline chars. Test included. Fixes #715 2011-01-20 17:48:44 -05:00
scottjehl
bfa6f6a3af Merge remote branch 'origin/master' 2011-01-20 16:28:28 -05:00
scottjehl
48b69b7a71 loading message opens above offset of active button, when possible. This makes it visible on devices that don't support scrollTop (webOS, etc) 2011-01-20 16:28:23 -05:00
Kin Blas
e4042266fb Fix for issue 841 - Persistent footers persist even when going to other pages that don't have footers or don't have footers with the same data-id. 
This was a regression I caused with my previous checkin. The fix is to simply null out stickyFooter in the pagebeforeshow callback.
 2011-01-20 12:51:28 -08:00
Kin Blas
161f5e6ae3 Removed jquery.js from js/index.php and updated all html doc/experiments/test files that incuded "js/" so that they also include jquery.js manually. 
This makes our include model match the include model on the CDN, and allows devs to make use of mobileinit for debugging some of the samples since that must be set up after jquery.js, but before jquery-mobile.
 2011-01-20 11:26:12 -08:00
John Bender
8a5060de13 fixed issue with dialog click handler breaking transitions on external links Fixes #642 2011-01-19 23:48:30 -08:00
John Bender
dcf9a19c31 whitespace issues in mobile core 2011-01-19 21:43:36 -08:00
scottjehl
f85e4c916b small workaround to get media query function to work on Nokia 2011-01-19 16:35:15 -05:00
Kin Blas
02c9264f0d Fix for issue 613 - Jquery Mobile ignores original 'base' tag defined in HTML 
- Fixed baseTagTest() in jquery.mobile.support.js, so that it uses any pre-existing base tag for testing. This fixes the bug on Webkit (Safari) where the relative paths for links were being resolved/expressed with the document path instead of the original base path.

- Modified the base code in jquery.mobile.navigation.js so that it uses the initial path of a pre-existing base tag, instead of always using the document path. This means that a document with a URL such as:

    http://foo.com/a/b/c#docs/pages/index.html

That uses a base tag like:

    <base href="http://foo.com/bar/">

Will resolve properly:

    http://foo.com/bar/docs/pages/index.html

so the mobile page gets loaded properly.

- Reduced the path.get() function down to a couple of regexp replace() calls.
 2011-01-18 09:18:22 -08:00
John Bender
b9bfa41846 poorly written comment 2011-01-15 23:36:59 -08:00
John Bender
f850311935 force previously created dialog for long menus. Fixes #807 2011-01-15 22:47:44 -08:00
John Bender
d4f4d474d1 whitespace cleanup for mobile forms select 2011-01-15 22:44:00 -08:00
Kin Blas
fde3aaaad5 Merge branch 'master' of https://github.com/jquery/jquery-mobile 2011-01-14 13:40:04 -08:00
Kin Blas
cd344f0440 Fix for Issue 811 - All resolution breakpoint classes added to <html> element, throws off label and form element flow on narrow screens. 
- We were firing off our fake orientationchange event before the viewport meta tag is injected. This causes us to get the default document width for the device which is much wider than the actual device-width. We now fire off the event after the dom ready event fires.
 2011-01-14 13:37:47 -08:00
maggiewachs
b6ec29a7e5 Fixed bug 676 where the switch toggle (slider) wasn't updating on select change: 
https://github.com/jquery/jquery-mobile/issues/labels/5%20-%20Critical#issue/676
 2011-01-14 16:06:18 -05:00
scottjehl
7cf5aea8e3 fixed up those busted select menu headers. Fixes #810 2011-01-14 15:49:21 -05:00
scottjehl
3b92410ff3 some additional changes to make scrolling from a select button work ok. 2011-01-14 15:16:03 -05:00
scottjehl
288fe45ff1 added option for useNativeMenu. Should be updated so, when set, the custom menu markup is never created. 2011-01-14 13:02:24 -05:00
Pavel Karoukin
5b4c23b67d add data-url to dialog 'pages' as well 2011-01-14 23:44:25 +08:00
Pavel Karoukin
794adfeca0 Click on form in dialog prevents exit from dialog 2011-01-14 23:44:24 +08:00
scottjehl
87c7b57da9 allow scroll to work when touch start begins on a select button. Fixes #804 2011-01-14 10:35:26 -05:00
Jonathan Hinkle
0413542753 rename selectmenu's exposed "options" to "optionElems" to avoid conflict with existing variable containing configuration options 2011-01-14 22:48:51 +08:00
ehynds
9e6a3df6b1 make sure the options cache is updated after a refresh, and that the click handler reads from this cache. 2011-01-12 22:01:50 +08:00
Jesse Streb
924c2c3e9b updated select to no longer wrap the input element as it is already jQuery object. Thanks ehynds. 2011-01-12 08:01:37 +08:00
Jesse Streb
5b238ea1ce https://github.com/jquery/jquery-mobile/issues#issue/578 Updated to use the selector that Scott suggested in order to make checkboxes not dissappear. One issue I noticed is that the page still transitions to the 'new' page even though it is really the same page. I have a fix for this that will post in a separate drop. 2011-01-12 08:01:36 +08:00
D. Elmo Peele
1a21b0581c Avoid triggering a 'tap' event if the event target on touchStop differs from the original touchStart target. 2011-01-12 07:47:17 +08:00
Kin Blas
5617d0c8d3 Merge branch 'delay_duplicateCachedPage' of https://github.com/medovob/jquery-mobile into pull662 
Had to fix merge conflicts in:
	js/jquery.mobile.navigation.js
 2011-01-11 14:12:07 -08:00
ehynds
95819c8c60 same fix in a few other places 2011-01-12 05:30:56 +08:00
ehynds
b71cc32d78 "this" in this context is already a jquery object 2011-01-12 05:30:56 +08:00
scottjehl
44d6064fb6 Merge branch 'no_enhance_for_hidden' of https://github.com/hynkle/jquery-mobile into hynkle-no_enhance_for_hidden 2011-01-11 13:42:30 -05:00
Kin Blas
8a70cdb3de Initial patch from pull 672 had incorrect check for backbtn data value. Changed it from $this.data("backbtn") === false to $this.data("backbtn") !== false to match the original logic that was in place prior to the patch. 
Original patch missed a nobackbtn reference in jquery.mobile.forms.select.js.
 2011-01-11 09:34:50 -08:00
Kin Blas
8050fb0d01 Merge branch 'master' of https://github.com/walkingeyerobot/jquery-mobile into pull672 2011-01-11 09:04:32 -08:00
John Bender
96d941ebe9 added the ability to disable ajax forms with data-ajax=false, attribute up for debate, Fixes #519 2011-01-08 23:47:07 -08:00
Jonathan Hinkle
6b799dad71 added 'hidden' to the types of inputs not to be enhanced by textinput 2011-01-07 12:33:59 -05:00
Kin Blas
c910f4b01f Fix for issues: 
470 - Multiple Footers when using data-position=fixed and data-id=[someid]

773 - The fixHeaderFooter pagebeforeshow live function is not triggered for the initial page shown

- Removed the findStickyFooter() function.

- Reworked the logic in the pagebeforeshow live function. We now add a ui-sticky-footer class to the sticky footer element. This will guarantee that we find the sticky footer if it already exists. We may at some point want to consider the use of ids on the sticky footers so that we don't have to crawl the entire document.

- Moved the live pagebeforeshow and pageshow calls outside of the DOMReady function so that they get registered as soon as the plugin is loaded. This guarantees that they will be triggered when the core plugin's DOMReady function fires.

- This fix makes issue/pull-request 765 obsolete.
 2011-01-07 01:07:22 -08:00
maggiewachs
926982b4f0 Fixed bug 595, where form elements were not properly inheriting the theme. Form controls need to be enhanced after the page containers so they'll pick up on the containers' theme classes. 2011-01-05 11:55:41 -05:00
John Bender
3a9652c9cc slider switch keyboard access tests Fixes #632 2010-12-26 23:09:11 -08:00
John Bender
06b83ad67a slider switch now keyboard enabled 2010-12-26 17:45:25 -08:00
scottjehl
53392bc7ca Merge branch 'issue_723' of https://github.com/ehynds/jquery-mobile into ehynds-issue_723 2010-12-23 14:34:17 -05:00
ehynds
edfafe0c01 if the close icon in a full-page select is clicked on, fire the selectmenu close handler instead of the dialog close handler 2010-12-23 13:19:34 -05:00
scottjehl
e9b076bcc0 Merge branch 'master' of https://github.com/louy/jquery-mobile into louy-master 2010-12-23 09:20:55 -05:00
John Bender
b2d58c1f30 slider keypress tests, comments, and style addition to navigation test page 2010-12-22 23:18:14 -08:00
John Bender
39729becd6 standard keyboard interaction working with slider, tests to come 2010-12-22 22:40:54 -08:00
John Bender
8ec3ae594d added keyCodes, Home and End working for range slider 2010-12-22 16:30:55 -08:00
Louy Alakkad
4dcb65fc7a fixing spaces 2010-12-22 07:53:07 -08:00
Louy Alakkad
59e8ee3137 Matching the jQuery code style guidelines. 2010-12-22 07:52:08 -08:00
scottjehl
fd821b7440 Merge branch 'select_multi' of https://github.com/ehynds/jquery-mobile into ehynds-select_multi 2010-12-22 10:05:40 -05:00
louy
ba99290480 Merge branch 'master' of git://github.com/jquery/jquery-mobile 2010-12-18 16:06:55 +02:00
louy
d435979daf Allow developer to apply themes on checkboxes/radio-buttons. 2010-12-18 15:20:15 +02:00
John Bender
b8babd1003 removed console log and added test for default transition 2010-12-16 19:12:58 -08:00
John Bender
7ffec259c5 added tests for explicit transition on back 2010-12-16 18:21:46 -08:00
John Bender
67aed1320b prefer explicit transition even when the url is popped of the stack Fixes #627 2010-12-16 18:20:17 -08:00
jzaefferer
e70c17d625 Extend nested listviews to accept more then just the title in parent list item. Currently requires predefined anchor to be present, based on discussion in ticket. Extended lists-nested.html to test both variants. Fixes #253 - only text nodes allowed in nested listview 2010-12-15 15:54:13 +01:00
Mitch Foley
ad757718c4 actually reversing backbtn logic this time. 2010-12-13 11:11:21 -05:00
Mitch Foley
df3bc91f80 renaming nobackbtn to backbtn. 2010-12-13 10:54:26 -05:00
John Bender
95ef08b269 perspective class only added on flip page transition or any transition added to the perspectiveTransitions local var in the transitionPages function Fixes #568 2010-12-13 02:21:40 -08:00
scottjehl
9420083a7b quick update to set the base.href back to the starting path, just in case, as some browsers may retain the base href after the element is removed from the DOM. Explained better here: b2add677f0 2010-12-11 13:50:07 -05:00
Kin Blas
3062199ac6 Some tweaks to kptdobe's patch from: 
https://github.com/jquery/jquery-mobile/pull/649

  - Changed hideOnTouchEnabed to touchToggleEnabled.
  - Fixed problem that would allow the toolbars to show on touchstop, if the starting state was "inline" to begin with.
  - Moved the touchToggleEnabled checks in touchstart/touchstop so that they wrap the entire code in the function. We don't want to do any work if we don't need to.
  - Removed the forced hide() call in touchstart.

Added the missing fadeout animation reference inthe fade.in transition rule.
 2010-12-10 10:17:16 -08:00
Richard Stutfield
0a87b59a04 Navigation: delay removal of duplicateCachedPage 2010-12-10 12:27:14 +00:00
kptdobe
9c3762978e Allow to disable headers hide on touch behavior 2010-12-09 15:02:45 +01:00
John Bender
553b58567f added protection for nested links to ui-bar selector with tests 2010-12-09 00:16:48 -08:00
John Bender
970f46c5e0 header and footer links will now remain unstyled, Fixes #524 2010-12-08 22:16:45 -08:00
ehynds
c982b93794 fixed a bug in single selects where clicking on a selected option would un-select it. this logic should only apply to multiple selects. 2010-12-08 15:45:23 -05:00
Kin Blas
4882c068b0 Modified loadComplete() so that it always fires off the "show" event. The idea here is that calling preventDefault() on a "hide" event shouldn't prevent the "show" event from being dispatched. Calling preventDefault() on the "show" event still prevents the "to" page from becoming the active page. 
Removed redundant target delcaration in the <a> live click callback.
 2010-12-08 12:40:21 -08:00
ehynds
1d2ef4f606 removed console.log statement 2010-12-08 09:43:24 -05:00
ehynds
43a6a3bb1b refactored header create logic to be consistent with the rest of the widget; fixed bug when using optgroups within a multiple select 2010-12-08 09:41:00 -05:00
ehynds
94ac0a88be fix placeholder logic 2010-12-07 18:05:26 -05:00
ehynds
9e30e54159 removed extraneous comment 2010-12-07 15:49:54 -05:00
ehynds
8eb553f884 multiple select functionality 2010-12-07 15:45:20 -05:00
scottjehl
80d56e655b Changed page navigation scripting to use data-url attributes instead of IDs for storing page URLs. This fixes a number of issues, most importantly #477, which exposed a conflict between jQuery's selector engine that would result in un-enhanced pages whenever linking between two pages in the same directory. 
The shift away from interal ID attribute usage also allows users to bind page events (pagecreate, pagebeforecreate) to a page div by its ID, which was a frequent cause of confusion when it didn't work as expected in former versions of the framework.

Seemingly unrelated: these commits allow you to specify data-role="dialog" in multipage and single page templates. In multipage templates, the role must be on the page (a link with data-rel alone will not work in multi-page). This addresses issue number 464, but may need further testing for obscure scenarios.

Fixes #477 (Pages are not enhanced when linking to a filename without a path)
Fixes #493 (Click the same link twice -> blank page)
Fixes #513 (closing dialog + returning to the same dialog)
Fixes #550 (changePage() not updating hash for internal pages - breaks )
Fixes #464 (Dialogs don't work within multi-pages)
Fixes #633 (Recent change to prevent same-page requests breaks select menu close button)
Fixes #599 (Page ids & page specific events)
Fixes #634 (After a bad page request, base url is not reset to current path)

booya.
 2010-12-07 12:05:10 -05:00
scottjehl
91a5b8c098 Changed the way submit buttons work. Now, form input/button elements are appended to a div-based "button", invisibly filling its width and height. The user now interacts directly with the native control, rather than having to trigger a click from another anchor (which formerly prevented some native submit event handling from working). 
A workaround is still included to ensure the input's name/value is submitted along with the form when it's not a type=reset, as this is necessary for the button data to appear in the serialized form data.
 2010-12-06 11:40:28 -05:00
scottjehl
2931fffb91 blur the active/focused element on changepage sooner. Thx @goulvench 2010-12-04 14:46:41 -05:00
scottjehl
74ebc360ca make sure hashchange event never causes additional hash changes to occur when responding with a page change 2010-12-04 13:13:55 -05:00
Jesse Streb
b725ff8f6a https://github.com/jquery/jquery-mobile/issues#issue/493 If changePage is called with to parameter that matches the current page we simply return out of the function 2010-12-04 13:13:55 -05:00
scottjehl
b01478a5e7 make sure forms can submit via ajax AND pass the clicked button's name/value in the serialized data. Fixes #605 2010-12-03 13:08:08 -05:00
scottjehl
6dce87a2ac hide placeholder options in selectmenu overlays. Fixes #607 2010-12-03 11:32:48 -05:00
ehynds
68150b5bec adding optgroup support. Fixes #567 2010-12-03 10:57:21 -05:00
ehynds
8062bf0a80 finish merge of select_event_bubbling or whatever i called that branch 2010-12-03 10:47:25 -05:00
ehynds
e2eb9e9298 add disabled option support. fixes #350 2010-12-03 22:30:08 +08:00
ehynds
12f011b7cc swap return false for event.preventDefault 2010-12-03 07:40:58 -05:00
scottjehl
9423bc199d fixed issue with listview corner rounding when listviews have only a couple items. 2010-12-01 16:35:17 -05:00
scottjehl
ce5ea07780 don't set hash if back is true. Fixes #582 2010-12-01 12:41:27 -05:00
scottjehl
54568271d9 pageshow and pagehide now fire after the location hash is updated. Fixes #583 2010-12-01 09:52:07 -05:00
scottjehl
17f0340a0a improved keepNative option so that it's additive on top of data-role=none and data-role=nojs. 2010-12-01 09:52:07 -05:00
scottjehl
efe4c38ad4 added the keepNative option to page plugin, which defaults to this selector "[data-role='none'], .ui-nojs". Add the attribute data-role="none" to any form control or anchor and it will not be auto-enhanced. Thx @pharaoh for the syntax suggestion. Fixes #544, Fixes #528, Fixes #529 2010-11-30 18:18:53 -05:00
scottjehl
419787affe make sure submit button name/value is submitted with form values. Fixes #551 2010-11-29 10:09:26 -05:00
scottjehl
d56380fc22 refactor of jquery.mobile.core.js. Moved all of the page navigation model related scripting into jquery.mobile.navigation.js. This includes event handling for click, submit, and hashchange, all of the base tag management, path management, active link class handling, etc. All existing core tests are passing, and all demos work as expected. More tests are needed in core, and this refactor should make those tests easier to write. 2010-11-25 06:13:51 -05:00
scottjehl
3cb0e3c2d0 fixed typo in propExists. thx @johnbender 2010-11-22 15:48:14 -05:00
scottjehl
a0596434bc moved the ID creation string escape function from core to listview. No other plugins use it. 2010-11-19 23:21:16 -05:00
scottjehl
ba5fea7f1e removed theme option from fieldcontain. ish didn't make no sense 2010-11-19 22:52:05 -05:00
scottjehl
93179f9a3d updated comment about license to match other jQuery projects - MIT "or" GPL 2010-11-19 22:47:47 -05:00
scottjehl
6711e11e97 made sure collapsible doesn't cause the address bar to show up on ios when clicked. Fixes #500 2010-11-19 21:32:17 -05:00
scottjehl
2ed21499d1 made sure address bar doesn't appear when opening select menu 2010-11-19 21:28:38 -05:00
scottjehl
d1c839613d made sure corners are removed on list items that used to be first or last when new items are appended. Fixes #400 2010-11-19 21:07:34 -05:00
scottjehl
a731e48e68 made sure select button gets active button class while open 2010-11-19 19:19:51 -05:00
scottjehl
76f5c26624 cleaned up css styles - ui-selectmenu instead of ui-listview 2010-11-19 19:15:48 -05:00
scottjehl
b2e306c667 removed theme coloring for selectmenu screen when in overlay mode. 2010-11-19 17:32:09 -05:00
scottjehl
b56939faf7 updated selectmenu to use position plugin for overlay version 2010-11-19 17:31:20 -05:00
scottjehl
23ea598b83 added jquery ui position plugin 2010-11-19 17:30:22 -05:00
John Bender
d0cca83be8 tests for default resolution break points, some missing semicolons, and element reference in each loop 2010-11-19 01:20:55 -08:00
scottjehl
ea8545928e shifted the order a little 2010-11-18 22:52:35 -05:00
scottjehl
9ff89b7115 renamed jquery.mobile.js jquery.mobile.core.js. updated build files, etc to match 2010-11-18 22:50:33 -05:00
scottjehl
909a0d0f08 removed transitions property from the configuration and updated docs to match. 2010-11-18 22:18:20 -05:00
scottjehl
e7269f4df2 moved orientationchange event trigger over to media js file. Cleaned up event bindings where orientation and breakpoint classes are applied. 2010-11-17 11:55:15 -05:00
scottjehl
82c48b2311 sorted breakpoints ascending after addition 2010-11-17 11:55:15 -05:00
scottjehl
2ade27bdcf removed old manifest files - index.php is now used in their place. 2010-11-17 11:55:15 -05:00
scottjehl
28a10ec74d Moved all of the media query and responsive design related scripting to jquery.mobile.media.js. This plugin can run independent of mobile core, with the exception that it does bind to orientationchange, which is defined in the events js. Fixes #388 2010-11-17 11:55:15 -05:00
scottjehl
5e90786374 added enable and disable methods to form buttons 2010-11-17 10:27:35 -05:00
Yuki KODAMA
2dea6cd721 implemented 'refresh' method for slider widget 2010-11-17 19:34:46 +09:00
Yuki KODAMA
d1e37647b8 added 'enable' and 'disable' methods to slider widget 2010-11-17 19:34:08 +09:00
scottjehl
2b226d05ce make sure pop'd page is defined before using. 2010-11-16 12:18:42 -05:00
Richard Stutfield
6603c84ef5 remove empty line 2010-11-16 22:56:49 +08:00
Richard Stutfield
d7a9d832db Fix form submit within a dialog. 2010-11-16 22:56:48 +08:00
Richard Stutfield
791f7aa61e Dialog: fixed links not working in dialogs. Fixed #448 - Dialog: clicking link in dialog closes dialog and doesn't do anything else 2010-11-16 22:56:48 +08:00
scottjehl
14b4c9a167 moved $.media function over to $.mobile object 2010-11-11 21:45:17 -05:00
scottjehl
e89ebc126e Input types can now degrade to alternate types, instead of text. First such example is type=range degrades to type=number. Fixes issue #415, Fixes #404 2010-11-11 21:43:01 -05:00
John Resig
573db6ab28 Just compare the nodes directly to each other. 2010-11-11 19:38:20 -05:00
John Resig
67174b8966 Updating jQuery to 1.4.4. 2010-11-11 19:21:03 -05:00
Kin Blas
1b12c54bcf Merge branch 'master' of https://github.com/jquery/jquery-mobile 2010-11-11 16:16:03 -08:00
Kin Blas
a77ca291e6 Fixed 59 - Fixed footer is anchored to the end of the page content instead of the view port. 
- If content is less than the view port height, the footer is always anchored at the bottom of the view port.
- If the content is greater in height than the view port, then in inline mode itrests in flow, and in "fixed" mode it snaps to the bottom of the view port.
 2010-11-11 16:08:45 -08:00
scottjehl
7a37d2507d fixed error in selectmenu close function 2010-11-11 19:01:02 -05:00
scottjehl
d3a0d33791 fixed up grids and navbar again - this time to automate the column count to number of children, or 'a' when greater than 5. data-grid attribute can be set to any grid letter to trump the automated counting. 2010-11-11 17:33:07 -05:00
scottjehl
78f342b5e0 fixed up the navbar and grid plugin logic. now supports up to 5 cols 2010-11-11 17:17:45 -05:00
scottjehl
5aa980fdb4 fixed a bug with icon positioning 2010-11-11 17:17:45 -05:00
John Resig
c9a34f1da2 Add versioning information to the headers of the CSS and JS files. 2010-11-11 17:02:45 -05:00
Kin Blas
dfa1a689a4 Fixed 432 - Fullscreen positioning don't work iPhone/Android/Desktop 
- $.mobile.activePage isn't being set till *AFTER* the "pageshow" notification, so pass in the page from our pageshow callback into the show() method.

- Also added missing getOffsetTop() call that I missed in my previous checkin.
 2010-11-11 13:39:54 -08:00
scottjehl
6502377d57 just comments 2010-11-11 15:08:57 -05:00
scottjehl
b7b553da84 missed a few files in that last commit. 2010-11-11 15:08:48 -05:00
scottjehl
055bf14e3f moved changePage, pageLoading, and silentScroll methods to $.mobile obj. 2010-11-11 15:03:40 -05:00
scottjehl
30c8a4cd5e removed $.mobile.headExtras - useless 2010-11-11 13:38:05 -05:00
scottjehl
d498e20aca typo on the data-iconpos check 2010-11-11 13:33:19 -05:00
scottjehl
25327445e0 null rather than undefined. woops 2010-11-11 13:33:19 -05:00
Kin Blas
1261fbc828 Bring iPad iOS 3.2.1 up to par with other platforms in terms of footer positioning. 2010-11-11 09:27:11 -08:00
scottjehl
f3c9716b52 extend rather than define 2010-11-11 11:28:02 -05:00
scottjehl
a24196e550 dolla dolla bills y'all. 
Fixes #126, Fixes #346
 2010-11-11 10:50:28 -05:00
scottjehl
aca0062ac0 workaround that seems to get selects returning to their proper place after making a selection. Needs tuning, but works for now. 2010-11-11 00:16:54 -05:00
scottjehl
dab3cbee34 changed to null for allowing override through data-theme 2010-11-10 23:58:38 -05:00
scottjehl
3a3953cd3f made sure text inputs / areas worked with data-theme 2010-11-10 23:54:01 -05:00
scottjehl
d03f3c6a33 nested lists were getting way small. This made em stop. 2010-11-10 23:50:14 -05:00
scottjehl
e8bd78bd27 fixed theming so data-theme and data-track-theme attrs work 2010-11-10 23:40:09 -05:00
scottjehl
0702e26221 added menuPageTheme and overlayTheme options. overlayTheme defaults to "a" to use the black stroke. 2010-11-10 23:39:48 -05:00
scottjehl
563169def9 made sure data-icon attrs work on radio and checks. Fixes #423, Fixes #424 2010-11-10 23:19:41 -05:00
scottjehl
bf3730550f used null where appropriate in options 2010-11-10 23:08:22 -05:00
scottjehl
049afd4568 improved defaults and added a demo page showing that all button data attrs work on selects too 2010-11-10 23:04:10 -05:00
scottjehl
532c918a26 updated data attribute support 2010-11-10 22:54:57 -05:00
scottjehl
91f287b3c6 improved enable/disable implementation 2010-11-10 22:48:31 -05:00
scottjehl
679094621f changed to button reference 2010-11-10 22:43:30 -05:00
scottjehl
691752afd2 added aria-disabled attrs 2010-11-10 22:42:50 -05:00
scottjehl
129b68741f moved menu building logic into _rebuild method, which is called by refresh if the option length is different than the list length (or if a true argument is passed to refresh(). Also moved mousedown events to "click", which dramatically improves keyboard navigation. 2010-11-10 22:31:05 -05:00
scottjehl
5716b89097 refactored select menu a bit to use new open and close methods 2010-11-10 21:40:20 -05:00
scottjehl
cc8c05091d changed transition to pop and make sure history change is false 2010-11-10 19:13:36 -05:00
scottjehl
b1bded6dde changed hideBrowserChrome function to "silentScroll". Scrolls to a particular location while disabling scroll event listening. 
Function accepts a Y positioning argument, or defaults to 0 if undefined.

Now page transitions cache their previous scroll position when leaving, and that position will be remembered when revisting that page.

This change also includes a fix for webOS to use this new feature and set the previous scroll to the location of the clicked selectmenu (so after using the select, it'll scroll back to its location, even though webOS doesn't support scrolltop)

Fixes #355
 2010-11-10 19:06:57 -05:00
scottjehl
ad2c894a74 Target attrs trigger now open a new window. Fixes #427 2010-11-10 18:12:18 -05:00
scottjehl
12b1bb4fa2 only degrade input types that conflict with our replacement UI control. For now, just search and range. Fixes #415, Fixes #420 2010-11-10 11:22:56 -05:00
scottjehl
3b5d12a207 shifting things around - mostly whitespace 2010-11-10 08:42:34 -05:00
scottjehl
6108ac90aa fixed issues with slider handle positioning when min isn't 0. Fixes #397 2010-11-10 08:37:04 -05:00
scottjehl
356308e6b7 updates to comments 2010-11-09 19:55:52 -05:00
scottjehl
f80428b1c6 updated slider to use widget factory. Fixes #370 2010-11-09 19:49:04 -05:00
scottjehl
812e4c6978 fixed support for back button closing of dialogs, utilizing new $.mobile.updateHash method. Fixes #412 2010-11-09 19:10:54 -05:00
scottjehl
f03e59b0b3 exposed $.mobile.updateHash to allow plugins to update the hash without triggering hashchange (when closing a dialog from back button for instance) 2010-11-09 19:08:57 -05:00
scottjehl
44d78d4853 changed so that nonHistorySelectors looks for both data-rel and data-role, meaning hash changes won't trigger hashchange handlers when dialogs are open 2010-11-09 18:58:09 -05:00
Kin Blas
6e9f8af1b3 Rule #1, when you change a file name, update its references. Fixing bustage from my previous checkin. Sorry 'bout that. 2010-11-09 14:09:04 -08:00
Kin Blas
d5a2ed2f10 Fixed 413 - Dev issue: our .htaccess file on the server is doing a 301 redirect which is causing css and image loading issues. 
- Switch to using a combine.php library and index.php scripts within each directory for combining files. This works around the iOS webkit bug that prevents images from being displayed the next time the page is loaded.
 2010-11-09 13:58:28 -08:00
scottjehl
58aa705391 updated comment 2010-11-09 16:08:15 -05:00
scottjehl
b02fc9f5e2 fixed filter listviews. wrong method name 2010-11-09 13:42:32 -05:00
D. Elmo Peele
97cc95dd0d Allow 'none' as a transition value. 2010-11-09 23:17:16 +08:00
scottjehl
734fb4d9b5 fixed theming of dialog body so it'll get C if no theme specified. Fixes #398 2010-11-08 22:20:09 -05:00
scottjehl
ca25127469 added refresh method and theme inheritance to selectmenu widget. Fixes #371 2010-11-08 21:24:44 -05:00
scottjehl
3b8067151e toggle ui-disabled class on disable/enable 2010-11-08 19:37:01 -05:00
scottjehl
f7a29fc201 converted selectmenu widget to the widget factory. 2010-11-08 19:33:45 -05:00
scottjehl
39c4b7b53b prepend to head immediately, instead of in a chunk later on 2010-11-08 19:26:30 -05:00
scottjehl
4b058096cf scoped to window 2010-11-08 19:23:27 -05:00
scottjehl
4b862bb114 triggered mobileinit event 2010-11-08 19:19:45 -05:00
scottjehl
0bb86f685f removed extend 2010-11-08 19:17:28 -05:00
scottjehl
32af18d59b added class ui-mobile-rendering to HTML el during initial build - will be used to prevent fouc 2010-11-07 15:20:35 -05:00
scottjehl
a405eda53f moved up top 2010-11-07 15:18:28 -05:00
scottjehl
facef32f3a changed to event.preventDefault 2010-11-07 15:17:59 -05:00
scottjehl
0972d65e04 prefixed var with $ 2010-11-07 15:03:40 -05:00
scottjehl
02e6e5f26b added $.mobile options: ajaxLinksEnabled, ajaxFormsEnabled. Both default to true. 2010-11-07 14:31:04 -05:00
scottjehl
1f7be112c8 make base options extendable via jQuery.mobile obj. 2010-11-06 16:04:59 -04:00
scottjehl
a1bef030dc filled out some comment documentation 2010-11-06 15:29:00 -04:00
scottjehl
294daf4008 cleaned up <head> markup insertion logic and added to new options to $.mobile hash: 
- metaViewportContent: "width=device-width, minimum-scale=1, maximum-scale=1",
- headExtras: undefined

If metaViewportContent is undefined, no viewport meta tag will be added to the dom.

headExtras is undefined by default, but allows for additional markup to be injected into the head element, such as meta tags used for enabling iOS local app features

Also, the <base> tag is defined as $base (undefined if support test is false), so setting its value no longer uses an ID selector to find it.
 2010-11-06 15:14:10 -04:00
scottjehl
95ff242b13 updated cssTransitions support test - was formerly failing in webkit, as it was checking for type of object, rather than function. Needs to be filled out with other css transitions events, along with our CSS itself. 
Also updated the animationComplete callback and got rid of a pointless timeout.
 2010-11-06 14:36:15 -04:00
scottjehl
3f703ce1e8 fixed regression where first page visited was using a transition. 2010-11-06 14:24:29 -04:00
scottjehl
f4b785a9e7 added loadingMessage to $.mobile hash, for i18n. Defaults to "loading". If set to false, loading message whill not appear during ajax requests, but ui-loading class will still apply to html element. 2010-11-06 14:18:03 -04:00
scottjehl
c707f63918 cleaned up vars for transition and back conditions - removed a couple unnecessary vars. Added $.mobile.defaultTransition, which defaults to "slide" but can be set to other transition names, or false, to disable default transitions (note: this won't prevent data-transition attrs from working when manually applied). 2010-11-06 14:04:59 -04:00
scottjehl
b0d1063ee8 moved device support conditions to $.mobile hash's gradeA property. Not terribly sophisticated yet, but least for now this allows for configuring device support conditions, which has been requested by users. 2010-11-06 13:45:09 -04:00
scottjehl
cec0939a61 changed comment 2010-11-06 13:45:09 -04:00
scottjehl
c0b37ec97d moved transitions to $.mobile hash, changed to array 2010-11-06 13:45:09 -04:00
scottjehl
72f3ca5765 move active page and button classes to the $.mobile hash 2010-11-06 13:45:09 -04:00
scottjehl
0c7860e7ed removed startPageId setting - not necessary 2010-11-06 13:45:09 -04:00
scottjehl
cdbccc2802 moved page-plugin-related options to the page plugin (backBtnText, addBackBtn, degradeInputs). 2010-11-06 13:45:09 -04:00
scottjehl
f7ce344578 moved configurable selector for non-history tracked links to the $.mobile hash. Renamed to $.mobile.nonHistorySelectors 2010-11-06 13:45:09 -04:00
scottjehl
925ac2b57a opened $.mobile to be extendable through $.mobileDefaults 2010-11-06 13:45:09 -04:00
Ben Alman
69e1e32c88 rewrote the orientationchange special event to allow both binding and unbinding of single or multiple event handlers as well as manual triggering. jQuery.event.special.orientationchange.orientation might not need to be public (which could save a few bytes). 2010-11-05 19:25:26 +00:00
scottjehl
0aa7fe6454 fixed listview splitbutton theming 2010-11-05 15:08:21 -04:00
scottjehl
c9bc4880a9 removed trailing comma. 2010-11-05 14:46:25 -04:00
scottjehl
a0815daf48 Fixed a few listview split button regressions. Fixes #387 2010-11-05 00:06:39 -04:00
D. Elmo Peele
95bac6f5a0 Fix tap event to ignore small movements. 2010-11-05 11:14:53 +08:00
scottjehl
aa6f842acc changed selector from [href] to link[href] for elements that need url-remapping in Firefox. This ensures only stylesheets, but not anchors, are being remapped. Fixes #381 2010-11-04 23:11:35 -04:00
scottjehl
3392be05d3 Added close() method to dialogs: $('.ui-dialog').dialog('close') . Also, links clicked within a dialog will now close the dialog on their way to their destination, just as if the dialog were a normal page. For links that are meant only for closing the dialog, such as a "cancel" link, just link to the page that triggered the dialog to open. This pattern of linking to the previous page happens to be meaningful in non-js browsing as well. If you are generating that link on the fly, just set its href to location.href. Fixes #383 2010-11-04 22:49:28 -04:00
scottjehl
b1f7ff9c2d made textinputs and textareas inherit theming when possible, or fall back to "c" 2010-11-04 21:59:03 -04:00
scottjehl
ffa682cbfe Converted textinput plugin to use widget factory. Also added enable and disable methods. Fixes #369 2010-11-04 21:32:28 -04:00
scottjehl
f29b85a149 converted collapsible to the widget factory. API change: data-state="collapsed" is now data-collapsed="true". Updated markup in demos to support change. Fixes #372 2010-11-04 21:32:28 -04:00
Kin Blas
b3ec50b2e3 Removed redundant setting of $.activePage that I added in my previous checkin. 
Updated lists-performance.html so that it is a list of 1000 items per Todd.
 2010-11-04 15:15:49 -07:00
scottjehl
64e0c1dc47 removed a timeout - reset hashListener to false within hashchange event handler 2010-11-04 11:50:17 -04:00
scottjehl
29a60d3c3e changed arg name to triggered 2010-11-04 11:24:39 -04:00
scottjehl
34283c04ed changed hashchange args to use array 2010-11-04 11:24:13 -04:00
scottjehl
81fe1d2aea Used documentElement.clientWidth/Height. Fixes #313 2010-11-04 10:44:35 -04:00
scottjehl
c45b0e3560 make sure "to" arg is an object, and has a url property before setting isFormRequest to true. 
Fixes #377
 2010-11-04 09:56:04 -04:00
scottjehl
3cc1c76d9d improved check for activePageLink existence 2010-11-04 09:56:04 -04:00
Kin Blas
bb5708e543 Some tweaks to make page scrolling faster. 
- Prevent the fixed header/footer code from traversing the entire document for each touchstart, touchend and scrollstart event.

- Make sure $.activePage is initialized with the startPage.
 2010-11-04 00:27:21 -07:00
scottjehl
a138877864 removed broad rule for rounding corners of thumbnail images in first and last slots of listviews. Now this only happens for inset listviews. Fixes #362 2010-11-03 22:26:09 -04:00
scottjehl
ea12c75940 Make sure that Ajax form submissions (both get and post) always make a new request, even if it's identical to a previous submission. When a duplicate cached result page is present, it'll be removed from the DOM after the page change is complete . Thanks @medovob for the ideas and feature request. Fixes #368, Fixes #366 2010-11-03 22:01:01 -04:00
scottjehl
fae3a93f26 remove active link class before leaving to an external page. Fixes #375 2010-11-03 18:56:21 -04:00
scottjehl
4036aa97e9 added an forceRemoval argument to make sure active states are removed when a page load error occurs. Fixes #364 2010-11-03 12:20:44 -04:00
scottjehl
f66047f410 added class 'ui-mobile-viewport-transitioning' to page parent container during transitions, and applied css to give perspective and proper dimension to the container and child pages. Also set overflow to hidden. 
Fixes #347
 2010-11-02 16:29:12 -04:00
scottjehl
edc1b81ba4 added ui-mobile-viewport class to parent of page element ( body in most cases). Updated css to style this class instead of body 2010-11-02 16:00:23 -04:00
scottjehl
cf4c1f858c Merge branch 'checkbox_selector' of http://github.com/mlins/jquery-mobile into mlins-checkbox_selector 2010-11-02 15:09:48 -04:00
Matt Lins
e66997b794 Use existing inputtype var 2010-11-02 13:31:09 -05:00
scottjehl
6700721437 added php to <? opening tags - thx @TechIsCool. Fixes #308 2010-11-02 14:24:17 -04:00
Dave Penfold
ae342659df Increase y axis threshold on swiping from 20 to 75 2010-11-03 02:12:05 +08:00
scottjehl
52f834cb8f post requests update the hash with url only - but no params 2010-11-02 01:23:27 -04:00
scottjehl
fa794ca0ee made sure external form actions are submitted through http 2010-11-02 00:57:27 -04:00
scottjehl
73e006d0e6 fixed a bug in relative url handling of form submissions 2010-11-02 00:48:46 -04:00
scottjehl
5e5f9387bf implemented simple automated form submission handling for get and post requests. added demo page which includes more information about how it works. 2010-11-01 23:56:42 -04:00
scottjehl
a4ae3b9c4c removed ajaxform plugin and experiments 2010-11-01 23:53:52 -04:00
scottjehl
9352d75487 removed ajaxform role 2010-11-01 23:53:35 -04:00
scottjehl
88a3c9ae57 updated to trigger a submit if the type is submit 2010-11-01 23:53:06 -04:00
scottjehl
f733dbb518 revised last commit - only header and footer inherit theming. content is left unthemed unless specified. 2010-11-01 22:54:41 -04:00
scottjehl
9ff1a1be6d allow header, content, and footer to inherit theming from the page element, if unspecified on the elements themselves. Fixes #282 2010-11-01 22:43:51 -04:00
scottjehl
1110f78659 additional normalization to urls for getting base url - now better accommodates starting urls that contain a filename 2010-11-01 21:28:10 -04:00
scottjehl
4f908e2c22 fixed closure arg - jQuery should have been $ 2010-11-01 14:34:39 -04:00
scottjehl
e4e8f1ddc4 added closures to event and support 2010-11-01 14:33:54 -04:00
scottjehl
4af621fd9d removed an old comment 2010-11-01 14:32:42 -04:00
Matt Lins
ea0470f099 Ensure more specific selector works for radio 2010-10-30 15:12:37 -05:00
Matt Lins
7e49a8f648 Use more specific selector for checkbox refresh 2010-10-30 14:47:03 -05:00
Jeffrey Way
aa4ff18e22 Small improvement to keep from querying the DOM more than once for the data-role=pages elements. 2010-10-29 02:21:24 +08:00
scottjehl
2e86ed1425 added support for enable and disable methods 2010-10-27 23:11:36 -04:00
scottjehl
7d03d097bf rewrote checkboxradio to use widget factory. renamed method checkboxradio and updated page plugin to match 2010-10-27 22:38:02 -04:00
scottjehl
c242604ec0 rewrote navbar with widget factory 2010-10-27 21:58:00 -04:00
scottjehl
c8d29fb6b2 added check to make sure active link isn't in the new activepage (such as when it's appended to the new page for persistence), before removing class 2010-10-27 21:57:37 -04:00
scottjehl
e202a72776 converted customButton plugin to widget factory (note: this is just the plugin for native button elements, not to be confused with the buttonMarkup plugin). 
renamed method to "button" and updated page.js to match
 2010-10-27 20:43:27 -04:00
scottjehl
77b1c3a758 moved line where # is removed to prevent base url prefixing on local anchor links 2010-10-27 16:56:03 -04:00
scottjehl
4c2a9591dc moved active class removal code into function - now called after ajax error as well as successful page change 2010-10-27 16:52:53 -04:00
scottjehl
096467e4eb made sure local # urls go through the regular page nav path, and only update the hash on success 2010-10-27 16:46:51 -04:00
scottjehl
d42aace51c removed a few chars from condition. Thx @jeffreyway for suggestions on the last few commits. 2010-10-27 16:27:10 -04:00
scottjehl
d26877fc22 used cached version of $this 2010-10-27 16:22:40 -04:00
scottjehl
f84daa9cd3 removed nullLink var 2010-10-27 16:21:27 -04:00
scottjehl
86f2d1f90a updated regexp to test for protocol or # at beginning of url. 2010-10-27 16:13:11 -04:00
scottjehl
07108b8809 simplified attr get/check 2010-10-27 15:00:56 -04:00
scottjehl
e709a37514 commented-out the call to _numberItems, as it doesn't yet exist in the listview rewrite 2010-10-27 12:19:24 -04:00
scottjehl
d299bfb087 moved append to before the buttonMarkup call, to make theming work as expected 2010-10-27 12:19:01 -04:00
scottjehl
1c79129dd6 removed title attr, as aria role handling seems to be descriptive enough 2010-10-27 09:49:45 -04:00
Alexander Dimitrov
1858844105 this keyword gets overwritten by jQuery.each 2010-10-26 22:53:28 +08:00
Karan Bhangui
f78d110339 fixed aside elements being displayed multiple times per list item 2010-10-26 22:53:11 +08:00
scottjehl
a382295724 removed a console.log 2010-10-25 11:06:43 -04:00
scottjehl
f12872c783 add/remove active class on clicked link. 2010-10-25 11:06:20 -04:00
scottjehl
4d3020d414 added px suffix to all media-min/max classes. Updated CSS usage to match. 2010-10-25 10:45:30 -04:00
scottjehl
a601db164d fixed typo in where the blank space was added. 2010-10-25 10:31:36 -04:00
scottjehl
13db7886df made sure empty min/max breakpoint classes aren't added 2010-10-24 09:43:34 -04:00
scottjehl
d7d43db120 made default breakpoints non-overrideable and exposed function $.mobile.addResolutionBreakpoints (accepts number or array of numbers) which can be used to add widths to be used in min/max media classes on HTML element. 2010-10-24 09:39:21 -04:00
scottjehl
0dcb2f2971 whitespace 2010-10-24 09:13:33 -04:00
scottjehl
e736caebfe Removed the ajaxClick function and moved its logic into the live click event handler, where it is now refactored and simplified. Thx to Jeffrey Way for ideas that went into this refactor. 
Also, clicks that are triggered on anchors will now be able to make a new http request, which improves listview behavior when clicking LIs that resolve to external urls.

Included in commit is a new demo/test page with various link types to make sure they behave as expected.

Fixes #272, Fixes #264
 2010-10-23 17:24:06 -04:00
scottjehl
6f5ce29175 typo 2010-10-23 17:16:49 -04:00
scottjehl
25c2ce5ce6 added support for grouped collapsibles that make accordions. Parent element just needs a data-role of collapsible-set. Fixes #87, Fixes #178 2010-10-23 10:20:06 -04:00
scottjehl
538a56caf6 Used triggerHandler instead of trigger to allow collapsibles to be embedded. Fixes #255 2010-10-23 08:57:54 -04:00
scottjehl
f32d9dddc1 click instead of tap 2010-10-22 19:00:22 -04:00
scottjehl
fe468ccc9e used click in place of tap 2010-10-22 18:59:42 -04:00
scottjehl
cf700ecfc1 e vs event. Fixed. 2010-10-22 18:59:14 -04:00
scottjehl
521b8e5eb7 moved the base tag check call to within the support extend. 2010-10-22 16:45:47 -04:00
scottjehl
e58c833f8c used indexOf instead of match. 2010-10-22 16:41:56 -04:00
hochi
dfaeae34bd fixed is() selector 2010-10-23 04:30:10 +08:00
scottjehl
6d54740f41 set max-width breakpoint classes as well. 2010-10-22 14:46:27 -04:00
scottjehl
38eb8aecc7 added - to prefix 2010-10-22 14:46:27 -04:00
scottjehl
e0f9c24b94 should have been minwidth prefixes, and now adding all that apply, rather than just the greatest. 2010-10-22 14:46:26 -04:00
John Resig
a5b4fdbaaa Fix typos. 2010-10-22 14:33:10 -04:00
John Resig
4f9d2e8ac8 Merge branch 'master' of github.com:jquery/jquery-mobile 2010-10-22 14:31:31 -04:00
John Resig
a8f8beaf74 Minor formatting and performance tweaks to the page plugin. 2010-10-22 14:31:24 -04:00
scottjehl
732b66057a resize and orientationchange now auto-add maxwidth classes to HTML element for common width breakpoints (defaults: 320,480,768,1024), which can be used in css targeting in place of media queries (for shorthand, and more importantly, to support IE, which may be opted-in to A support). 2010-10-22 13:58:08 -04:00
John Resig
d55fce4a47 Merge branch 'master' of github.com:jquery/jquery-mobile 2010-10-22 12:42:33 -04:00
John Resig
62623ca68e Made a bunch of tweaks to checkbox/radio. 2010-10-22 12:42:24 -04:00
scottjehl
70bba7064a Added a support test $.support.dynamicBaseTag and workaround for browsers that don't support dynamically updating BASE tag (Firefox is the only one I've seen so far. In those browsers, when a new page is fetched, any elements with href and src attributes will have their attribute prefixed with a proper base url (if they don't already start with an external site http address, "/", "#", or any protocol such as "mailto:, etc). 
In the process, the BASE element and related functions are only implemented if that support is true, and BASE urls now use a full URL path when set, to avoid issues with browsers that may need that.

Fixes #263, Fixes #221
 2010-10-22 12:31:25 -04:00
John Resig
8208b6b986 Minor tweaks to page formatting. 2010-10-22 12:22:57 -04:00
John Resig
a07bcbaa8b Minor tweaks to page logic. 2010-10-22 12:17:14 -04:00
John Resig
87106e4e61 Make sure that listview classes are only set per row. 2010-10-22 11:48:54 -04:00
John Resig
c8b5728c21 Fix issues with button rendering. 2010-10-22 11:39:26 -04:00
John Resig
170b02d795 Pull in updated version of jQuery. 2010-10-22 11:38:07 -04:00
John Resig
683d73243c Reduced number of calls to addClass. 2010-10-21 18:36:17 -04:00
John Resig
f91b2523ff Merge clickable into buttonMarkup. Improve performance of the Button Markup plugin. 2010-10-21 17:18:59 -04:00
scottjehl
21a7b0a2ba updated to reflect new changes in pageChange function and dialog behavior 2010-10-21 17:02:59 -04:00
scottjehl
e71cb716a2 Merge branch 'master' of github.com:jquery/jquery-mobile 
Conflicts:
	js/jquery.mobile.js
 2010-10-21 16:47:32 -04:00
scottjehl
ef3fd116dc refactored to use widget factory and not be tracked via hash/history. Fixes #176 2010-10-21 16:29:05 -04:00