Marius Gedminas
947b108f9e
Make test_telnet.py fast
...
Linkchecker's telnet://username:password@host:port URL verification logic is
- connect to host:port
- wait for 'login: ' to appear (with a 10 second timeout), send username
- wait for 'Password: ' to appear (with a 10 second timeout), send password
The test spawns a fake telnet server on localhost that never presented
the login/password prompts, forcing the 10 second timeout three times.
This commit makes the fake telnet server emit the expected prompts,
making the test pass in .2 seconds.
2019-04-27 21:52:33 +03:00
Marius Gedminas
3a7c2a9823
Merge pull request #255 from linkchecker/stop-threads-more-reliably
...
Stop threads more reliably
2019-04-27 21:51:34 +03:00
anarcat
9c9706a07a
Merge pull request #256 from cjmayo/parse_qs
...
Replace deprecated cgi.parse_qs
2019-04-27 13:27:19 -04:00
anarcat
d022ad49ac
Merge pull request #257 from cjmayo/startexp
...
Replace deprecated regexp flags not at start
2019-04-27 13:26:59 -04:00
Chris Mayo
a355476b82
Replace deprecated regexp flags not at start
...
DeprecationWarning: Flags not at the start of the expression
2019-04-26 19:25:59 +01:00
Chris Mayo
5ae40c1ae2
Replace deprecated cgi.parse_qs
2019-04-26 19:23:45 +01:00
Marius Gedminas
068e9bae8d
Stop the telnet server threads more reliably
...
Instead of speaking text-based protocols over TCP we can use
threading.Event() objects to indicate the desire for the server thread
to quit.
2019-04-26 01:10:36 +03:00
Marius Gedminas
8489730eac
Print the names of the hanging tests
...
In cast we forget or somebody else wants to tackle this. After all, the
assertion error + traceback shows up at the end of the test run, and
it's not immediately clear which test is to blame for it!
2019-04-26 00:57:21 +03:00
Marius Gedminas
e285b0f257
Wow this test _is_ actually very slow!
...
tox -e py27 -- tests/checker/test_telnet.py takes 30 seconds to
complete. That seems excessive to me, but one thing at a time.
2019-04-26 00:23:51 +03:00
Marius Gedminas
e9fb9b01bf
Fix a hanging test on Python 3
...
I'm not entirely sure why the test is hanging, but this seems clear
enough:
- the test setup spawns a (non-daemon) background thread that runs
forever, or until it is told to quit by receiving a TCP packet on a
certain port
- the test teardown tries to tell the background thread to quit (which
doesn't work) and waits for that to happen
- as a result the entire test run hangs forever
This commit adds a timeout as an extra safety net so that the test run
will complete even if the clean shutdown procedure fails for some
reason.
2019-04-26 00:15:10 +03:00
anarcat
b65e0f9d4c
Merge pull request #244 from cjmayo/fixes
...
Fix mistakes in changes to test_dummy.py and test_updater.py in 8f4acc31
2019-04-25 16:20:44 -04:00
anarcat
59fe9ed876
Merge pull request #228 from cjmayo/python3_18
...
{python3_18} Python3: fix unicode in urlbase
2019-04-25 16:17:00 -04:00
anarcat
70f0bbf225
Merge pull request #250 from cjmayo/ftpserver
...
Get FtpServerTest working by updating to current pyftpdlib API
2019-04-25 16:16:33 -04:00
anarcat
095c6c57d4
Merge pull request #252 from cjmayo/init
...
Make test_all_parts TestLogger import Python 3 compatible
2019-04-25 15:54:26 -04:00
Chris Mayo
5caa683123
Make test_all_parts TestLogger import Python 3 compatible
...
tests/checker/test_all_parts.py:21: in <module>
import __init__ as init
E ModuleNotFoundError: No module named '__init__'
testWarning: cannot collect test class 'TestLogger' because it has a
__init__ constructor
2019-04-25 20:28:21 +01:00
anarcat
243dedf3bc
Merge pull request #247 from cjmayo/robots37
...
Make TestRobotsTxt Python 3.7 compatible
2019-04-25 15:21:35 -04:00
anarcat
7767bc52fa
Merge pull request #216 from cjmayo/python3_06
...
{python3_06} Python3: fix tests init - exceptions and string
2019-04-25 15:20:55 -04:00
Petr Dlouhý
e92b0a9f7b
Python3: fix unicode in urlbase
2019-04-25 19:57:45 +01:00
Petr Dlouhý
b3881ce3b5
Python3: fix urlbase, strformat and others
2019-04-25 19:57:45 +01:00
Petr Dlouhý
5e918cef53
Python3: fix tests init - exceptions and string
2019-04-25 19:35:09 +01:00
anarcat
056ba1d717
Merge pull request #248 from cjmayo/donateurl
...
Remove configuration.DonateUrl
2019-04-24 10:59:50 -04:00
anarcat
b656346352
Merge pull request #246 from cjmayo/locale_format
...
Replace deprecated locale.format()
2019-04-24 10:59:17 -04:00
anarcat
4b3d91ffea
Merge pull request #245 from cjmayo/future_str
...
Import str as str_text from builtins when supporting transition
2019-04-24 10:59:04 -04:00
anarcat
a42bc14fc2
Merge pull request #243 from cjmayo/warning
...
Replace deprecated log.warn
2019-04-24 10:58:31 -04:00
anarcat
bb0a1e1992
Merge pull request #242 from cjmayo/wummel
...
Update references to GitHub project from wummel to linkchecker
2019-04-24 10:58:15 -04:00
anarcat
ee8667e1ca
Merge pull request #229 from cjmayo/python3_19
...
{python3_19} Python3: fix unicode in fileurl
2019-04-24 10:57:45 -04:00
anarcat
492da5aee0
Merge pull request #227 from cjmayo/python3_17
...
{python3_17} Python3: fix unicode in url.py
2019-04-24 10:57:09 -04:00
anarcat
8219b976ac
Merge pull request #223 from cjmayo/python3_13
...
{python3_13} Python3: fix imports in test_noproxy
2019-04-24 10:56:50 -04:00
anarcat
5916206f5f
Merge pull request #220 from cjmayo/python3_10
...
{python3_10} Python3: fix httpserver tests
2019-04-24 10:56:17 -04:00
anarcat
73e57de3fd
Merge pull request #213 from cjmayo/python3_03
...
{python3_03} Python3: fix HtmlParser
2019-04-24 10:55:24 -04:00
Chris Mayo
8678feaa59
Make TestRobotsTxt Python 3.7 compatible
...
urllib.parse.quote() moved from RFC 2396 to RFC 3986 for quoting URL
strings. "~" is now included in the set of reserved characters.
https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote
2019-04-22 19:50:32 +01:00
Chris Mayo
f60810b050
Fix Python 3 "TypeError: decoding str is not supported" in FtpUrl.cwd
2019-04-22 19:34:46 +01:00
Chris Mayo
64e9392fb9
Get FtpServerTest working by updating to current pyftpdlib API
2019-04-22 19:34:46 +01:00
Chris Mayo
20e11f1b1f
Remove configuration.DonateUrl
2019-04-21 19:44:18 +01:00
Chris Mayo
ce1dd55d7a
Replace deprecated locale.format()
...
locale.format_string() was introduced in Python 2.5.
2019-04-21 19:28:54 +01:00
Petr Dlouhý
b40f4722c7
Python3: fix unicode in fileurl
2019-04-19 20:42:38 +01:00
Petr Dlouhý
f4b73c6d42
Python3: fix unicode in url.py
2019-04-19 19:57:25 +01:00
Chris Mayo
d8a52381f2
Import str as str_text from builtins when supporting transition
...
Expected to be removed when the project moves to Python 3 only.
2019-04-19 19:25:50 +01:00
Chris Mayo
0031bbdccc
Fix mistakes in changes to test_dummy.py and test_updater.py in 8f4acc31
2019-04-19 19:22:38 +01:00
Chris Mayo
46179f681c
Replace deprecated log.warn
...
warning() has been the documented method since logging was introduced in
Python 2.3.
2019-04-18 20:10:03 +01:00
EsuS
004632a99b
Update references to GitHub project from wummel to linkchecker
...
Remove all mention of donations.
2019-04-18 19:59:52 +01:00
Petr Dlouhý
bc99dc51de
Python3: fix HtmlParser
2019-04-18 19:35:16 +01:00
anarcat
5d26d2d93e
Merge pull request #212 from cjmayo/python3_02
...
{python3_02} Python3: fix regexp format
2019-04-17 15:46:56 -04:00
Petr Dlouhý
2c6411d68e
Python3: fix regexp format
2019-04-17 19:50:06 +01:00
anarcat
9d57bee16f
Merge pull request #218 from cjmayo/python3_08
...
{python3_08} Python3: use str and basestring from builtins
2019-04-17 09:04:35 -04:00
anarcat
da271dd482
Merge pull request #239 from cjmayo/sorted
...
Fix TestFile results not always ordered as expected values
2019-04-17 09:03:40 -04:00
Marius Gedminas
85cee2138d
Fix TestFile results not always ordered as expected values
...
self = <tests.checker.test_file.TestFile testMethod=test_good_dir_space>
def test_good_dir_space (self):
...
> self.direct(url, resultlines, recursionlevel=2)
tests/checker/test_file.py:173:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests/checker/__init__.py:260: in direct
self.fail_unicode(text(os.linesep).join(l))
tests/checker/__init__.py:237: in fail_unicode
self.fail(msg)
E AssertionError: Differences found testing
2019-04-16 20:25:16 +01:00
Petr Dlouhý
8f4acc3168
Python3: use str and basestring from builtins
2019-04-16 20:08:29 +01:00
anarcat
e93d18d6e9
Merge pull request #232 from cjmayo/gzip2
...
Remove leftovers from introduction of requests
2019-04-15 10:31:06 -04:00
anarcat
cfd81031d1
Merge pull request #233 from cjmayo/python3_05a
...
{python3_05a} Use Python 3 compatible octal masks
2019-04-15 10:30:13 -04:00